Skip to content

Pin vllm version#140

Merged
chrisalexiuk-nvidia merged 5 commits intomainfrom
pin-vllm-version
Apr 10, 2026
Merged

Pin vllm version#140
chrisalexiuk-nvidia merged 5 commits intomainfrom
pin-vllm-version

Conversation

@chrisalexiuk-nvidia
Copy link
Copy Markdown
Contributor

Updating Version to Nightly

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
@chrisalexiuk-nvidia
Copy link
Copy Markdown
Contributor Author

/claude review

Comment thread usage-cookbook/Nemotron-3-Super/SparkDeploymentGuide/README.md Outdated
Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
@chrisalexiuk-nvidia
Copy link
Copy Markdown
Contributor Author

/claude review

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisalexiuk-nvidia
Copy link
Copy Markdown
Contributor Author

/claude review

@claude
Copy link
Copy Markdown

claude Bot commented Apr 10, 2026

This PR currently has no net diff against main. The commit history shows the image was changed to v0.18.1-cu130, then reverted back to cu130-nightly, and after the merge from main, the branch is identical to the base branch (0 additions, 0 deletions, 0 files changed). Was this intentional, or should there still be a change here?

Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com>
@chrisalexiuk-nvidia
Copy link
Copy Markdown
Contributor Author

/claude review

@claude
Copy link
Copy Markdown

claude Bot commented Apr 10, 2026

LGTM

Minor note: the PR title says "Pin vllm version" but the change actually moves from a pinned release tag (v0.18.1-cu130) to a rolling nightly tag (cu130-nightly). Consider updating the title to match the intent (e.g., "Update vLLM image to nightly").

@chrisalexiuk-nvidia chrisalexiuk-nvidia merged commit d55fc21 into main Apr 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants