Fix embedding SDG dedup compatibility.#147
Open
hoangnguyenN94 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
Fix embedding SDG dedup compatibility.#147hoangnguyenN94 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
hoangnguyenN94 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Use Data Designer's public embedding facade API so Stage 0 dedup continues working after the private router interface change. Made-with: Cursor
| # Data Designer's public embedding API moved behind ModelFacade methods. | ||
| # Use the facade directly rather than reaching into removed private attrs | ||
| # like `_router`, which breaks across library versions. | ||
| response = self.embedder.generate_text_embeddings( |
Contributor
There was a problem hiding this comment.
@hoangnguyenN94 please could you update the data-designer dependency in the pyproject.toml of this retriever-sdg package to data-designer>=0.5.3 since that was the version that made the breaking change to _router
Author
There was a problem hiding this comment.
@oliverholworthy I have updated data-designer>=0.5.3, and re-build, but still error: 🛑 Failed to load plugin from entry point 'data-designer-retrieval-dedup': partially initialized module 'retriever_sdg.deduplication' has no attribute 'dd_retrieval_dedup_plugin' (most likely due to a circular import)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Data Designer's public embedding facade API so Stage 0 dedup continues working after the private router interface change.