Skip to content

ci: Run nemo gym unit tests on Github#2292

Open
chtruong814 wants to merge 11 commits intomainfrom
chtruong/gym-test
Open

ci: Run nemo gym unit tests on Github#2292
chtruong814 wants to merge 11 commits intomainfrom
chtruong/gym-test

Conversation

@chtruong814
Copy link
Copy Markdown
Contributor

@chtruong814 chtruong814 commented Apr 19, 2026

What does this PR do ?

ci: Run nemo gym unit tests on Github

Currently the nemo gym unit tests are only ran as part of our nightly tests. However, we should be able to run this on Github now.

  • Add nemo-gym-only test marker
  • Updated "other" unit tests to run nemo gym tests
  • Fix gym rollout test due to changed expected keys
  • Fix gym sanity test by updating the expected json file. It seems that this is now failing after Gym commit was updated recently
    • The test script is updated to always write a actual_test_nemo_gym_sanity.json file if we need to update it again and writes to a Github artifact
    • It seems the main difference with the original file is that Gym removed "strict": true from its tool calls for this test.

https://github.com/NVIDIA-NeMo/Gym/pull/944/changes#diff-b56c7f31b7793b3a4ac265f84f4c84216f1ed15a3fbee855da9674a7da8714ffR571

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested review from a team as code owners April 19, 2026 17:12
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 19, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@chtruong814 chtruong814 added the CI:L0 Run doctests and unit tests label Apr 19, 2026
@chtruong814
Copy link
Copy Markdown
Contributor Author

/ok to test

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@github-actions github-actions bot added the CI Relating to CI label Apr 19, 2026
@chtruong814
Copy link
Copy Markdown
Contributor Author

/ok to test

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Copy Markdown
Contributor Author

/ok to test

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Copy Markdown
Contributor Author

/ok to test

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Copy Markdown
Contributor Author

/ok to test

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Copy Markdown
Contributor Author

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L0 Run doctests and unit tests CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant