fix: upgrade xgrammar to 0.1.32 for CVE-2026-25048#271
Merged
Conversation
vllm 0.15.0 pins xgrammar==0.1.29 which is affected by CVE-2026-25048 (GHSA-7rgv-gqhr-fxg3). Add a dependency override to force >=0.1.32,<1.0.0 -- the same range vllm adopted upstream in vllm-project/vllm#36168. 802 unit tests pass with no regressions. Signed-off-by: Kendrick Boyd <kendrickb@nvidia.com> Made-with: Cursor
Collaborator
Author
|
/sync |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR remediates CVE-2026-25048 by overriding vLLM’s transitive pin on xgrammar==0.1.29 to allow xgrammar>=0.1.32,<1.0.0, and refreshes the lockfile accordingly (including dropping now-unneeded macOS-only MLX dependencies).
Changes:
- Add a
tool.uv.override-dependenciesentry to forcexgrammar>=0.1.32,<1.0.0. - Update
uv.lockto resolvexgrammarto0.1.32. - Remove
mlx,mlx-lm, andmlx-metalentries from the lockfile due toxgrammardropping the transitive dependency.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pyproject.toml |
Adds an explicit uv override to ensure xgrammar is resolved to a non-vulnerable version range. |
uv.lock |
Reflects the new resolution (xgrammar 0.1.32) and removes obsolete MLX-related packages from the lock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mckornfield
approved these changes
Mar 19, 2026
binaryaaron
approved these changes
Mar 19, 2026
Collaborator
|
might want to file an issue to remove the pin someday since we've goofed that before; ty! |
Collaborator
Author
|
Filed #273. Going ahead and merging since dp and non-dp tests worked locally with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xgrammar==0.1.29to>=0.1.32,<1.0.0to remediate CVE-2026-25048 (GHSA-7rgv-gqhr-fxg3)mlx-lmdependency, somlx,mlx-lm, andmlx-metalare removed from the lockfileTest plan
uv lockresolves cleanly (xgrammar 0.1.29 → 0.1.32)make bootstrap-nss cudainstalls successfullymake test-- 802 passed, 2 skipped, 0 failuresmake test-e2erun locallyMade with Cursor