Skip to content

fix: upgrade xgrammar to 0.1.32 for CVE-2026-25048#271

Merged
kendrickb-nvidia merged 1 commit into
mainfrom
fix/xgrammar-cve-2026-25048
Mar 19, 2026
Merged

fix: upgrade xgrammar to 0.1.32 for CVE-2026-25048#271
kendrickb-nvidia merged 1 commit into
mainfrom
fix/xgrammar-cve-2026-25048

Conversation

@kendrickb-nvidia

@kendrickb-nvidia kendrickb-nvidia commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • uv lock resolves cleanly (xgrammar 0.1.29 → 0.1.32)
  • make bootstrap-nss cuda installs successfully
  • make test -- 802 passed, 2 skipped, 0 failures
  • make test-e2e run locally
    • tests/e2e/test_safe_synthesizer.py::test_train_and_generate_defaults PASSED
    • tests/e2e/test_safe_synthesizer.py::test_train_and_generate_dp PASSED

Made with Cursor

vllm 0.15.0 pins xgrammar==0.1.29 which is affected by
CVE-2026-25048 (GHSA-7rgv-gqhr-fxg3). Add a dependency override
to force >=0.1.32,<1.0.0 -- the same range vllm adopted upstream
in vllm-project/vllm#36168.

802 unit tests pass with no regressions.

Signed-off-by: Kendrick Boyd <kendrickb@nvidia.com>
Made-with: Cursor
@kendrickb-nvidia kendrickb-nvidia requested a review from a team as a code owner March 19, 2026 20:53
Copilot AI review requested due to automatic review settings March 19, 2026 20:53
@kendrickb-nvidia

Copy link
Copy Markdown
Collaborator Author

/sync

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR remediates CVE-2026-25048 by overriding vLLM’s transitive pin on xgrammar==0.1.29 to allow xgrammar>=0.1.32,<1.0.0, and refreshes the lockfile accordingly (including dropping now-unneeded macOS-only MLX dependencies).

Changes:

  • Add a tool.uv.override-dependencies entry to force xgrammar>=0.1.32,<1.0.0.
  • Update uv.lock to resolve xgrammar to 0.1.32.
  • Remove mlx, mlx-lm, and mlx-metal entries from the lockfile due to xgrammar dropping the transitive dependency.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Adds an explicit uv override to ensure xgrammar is resolved to a non-vulnerable version range.
uv.lock Reflects the new resolution (xgrammar 0.1.32) and removes obsolete MLX-related packages from the lock.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@binaryaaron

Copy link
Copy Markdown
Collaborator

might want to file an issue to remove the pin someday since we've goofed that before; ty!

@kendrickb-nvidia

Copy link
Copy Markdown
Collaborator Author

Filed #273.

Going ahead and merging since dp and non-dp tests worked locally with make test-e2e

@kendrickb-nvidia kendrickb-nvidia merged commit d8e9a9b into main Mar 19, 2026
22 checks passed
@kendrickb-nvidia kendrickb-nvidia deleted the fix/xgrammar-cve-2026-25048 branch March 19, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants