Rectified logic for system prompt and audio trimming.#1298
Draft
ankitapasad wants to merge 8 commits into
Draft
Conversation
Signed-off-by: Ankita Pasad <apasad@nvidia.com>
Signed-off-by: Ankita Pasad <apasad@nvidia.com>
Signed-off-by: Ankita Pasad <apasad@nvidia.com>
Signed-off-by: Ankita Pasad <apasad@nvidia.com>
Signed-off-by: Ankita Pasad <apasad@nvidia.com>
melllinia
reviewed
Mar 10, 2026
| if self.v2_config.pad_to_duration_secs is not None: | ||
| return float(self.v2_config.pad_to_duration_secs) | ||
| if self.v2_config.silence_padding_sec > 0: | ||
| if self.v2_config.silence_padding_sec >= 0: |
Member
There was a problem hiding this comment.
Was the change from > 0 to >= 0 intentional? With >= 0, a value of 0 will return duration instead of None, but adding 0 doesn’t change the result.
melllinia
reviewed
Mar 10, 2026
| def main(): | ||
| parser = argparse.ArgumentParser(description="Prepare FLEURS data for nemo-skills ASR evaluation") | ||
| parser.add_argument( | ||
| "--manifest_path", |
Member
There was a problem hiding this comment.
Normally, we download the official benchmarks from HF, but since this is just an experimental implementation, I think reading from the manifest path is fine for now.
Signed-off-by: Ankita Pasad <apasad@nvidia.com>
melllinia
approved these changes
Mar 11, 2026
Signed-off-by: Ankita Pasad <apasad@nvidia.com>
Signed-off-by: Ankita Pasad <apasad@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--silence_padding_sec 0.0to make sure no additional silence is added to the audio, leading to inflated ToR scores. Previously,silence_padding_secwould assume the default value of 5 seconds.