Skip to content

Customize num_tasks per node in run_cmd #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artbataev merged 2 commits into from
Oct 17, 2025
Merged

Customize num_tasks per node in run_cmd #965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
600c105
Customize num tasks per node in `run_cmd`
artbataev Oct 17, 2025
45fb504
Merge branch 'main' into customize_num_tasks
artbataev Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions nemo_skills/pipeline/run_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,9 @@ def run_cmd(
),
qos: str = typer.Option(None, help="Specify Slurm QoS, e.g. to request interactive nodes"),
time_min: str = typer.Option(None, help="If specified, will use as a time-min slurm parameter"),
num_gpus: int | None = typer.Option(None, help="Number of GPUs to use"),
num_gpus: int | None = typer.Option(None, help="Number of GPUs per node to use"),

@Kipok Kipok Oct 17, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a good idea to update message in all pipelines, not just here

num_nodes: int = typer.Option(1, help="Number of nodes to use"),
num_tasks: int = typer.Option(1, help="Number of tasks per node"),
model: str = typer.Option(None, help="Path to the model to evaluate"),
server_address: str = typer.Option(None, help="Address of the server hosting the model"),
server_type: pipeline_utils.SupportedServers | None = typer.Option(None, help="Type of server to use"),
Expand Down Expand Up @@ -198,7 +199,7 @@ def run_cmd(
task_dependencies=prev_tasks,
num_gpus=num_gpus,
num_nodes=num_nodes,
num_tasks=[1] * len(commands),
num_tasks=[num_tasks] * len(commands),
slurm_kwargs={"exclusive": exclusive} if exclusive else None,
installation_command=installation_command,
skip_hf_home_check=skip_hf_home_check,
Expand Down