[DEMO] WrenchComposer zero-range regression on perf-smoke (RED)#9
Open
Neil4561 wants to merge 2 commits into
Open
[DEMO] WrenchComposer zero-range regression on perf-smoke (RED)#9Neil4561 wants to merge 2 commits into
Neil4561 wants to merge 2 commits into
Conversation
added 2 commits
June 25, 2026 18:53
…m#5265 Remove the all-zero early-return guard in apply_external_force_torque so every step samples and sets zero-magnitude forces through the WrenchComposer path instead of short-circuiting. Reproduces upstream isaac-sim#5265 (~throughput hit on locomotion/velocity tasks whose external-force event uses all-zero ranges, e.g. Isaac-Velocity-Flat-G1-v0). Demo only; not for merge.
Trim to three well-baselined demo tasks (Cartpole physx/newton, Factory physx, G1 physx/newton) for a clean multi-row verdict table. Demo only; not for merge.
Performance Smoke ResultsBaseline read SHA: Run context
How to read this table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo PR (not for merge)
RED case for the performance smoke-test demo.
Change: reintroduces the WrenchComposer regression from upstream isaac-sim#5265.
Explanation: some environments configure an external force event with force and torque set to zero. That means "do not actually push the robot." The normal code sees that everything is zero and skips the work. This PR removes that shortcut, so the simulator still goes through the WrenchComposer path to write zero forces and zero torques into the wrench buffers. The physical result is the same, but the simulator does extra bookkeeping work, which shows up as lower FPS on affected tasks.
Isaac-Velocity-Flat-G1-v0is the important affected task in the demo because it exercises that external-wrench path.CartpoleandFactoryact as controls: they stay near baseline, showing that the regression is not a global slowdown across every benchmark cell.Matrix:
Isaac-Cartpole-Direct+Isaac-Factory-GearMesh-Direct-v0(physx) +Isaac-Velocity-Flat-G1-v0.Trigger via mirror to
pull-request/<N>orworkflow_dispatch.