Add multi-configuration performance benchmarking #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
CI MESSAGE: [25999015]: BUILD STARTED |
|
CI MESSAGE: [25999015]: BUILD FAILED |
- Add support for range-based arguments for CPU threads and HW decoder load - Implement performance testing across multiple configurations - Add best throughput configuration reporting - Enhance performance metrics with more detailed statistics - Refactor pipeline definitions to support variable HW decoder load Signed-off-by: Janusz Lisiecki <[email protected]>
|
!build |
|
CI MESSAGE: [25999773]: BUILD STARTED |
|
CI MESSAGE: [25999773]: BUILD PASSED |
internal_tools/hw_decoder_bench.py
Outdated
|
|
||
| @pipeline_def( |
There was a problem hiding this comment.
pipeline definitions could be outside of the loops, for better readibility.
| print(f"Total time: {best_result['total_time']:.6f} sec") | ||
| print(f"Throughput: {best_result['total_throughput']:.2f} frames/sec") | ||
| else: | ||
| print("No results to display") |
There was a problem hiding this comment.
an idea, print the results for all parameters in a way that can be easily parsed and plotted.
There was a problem hiding this comment.
Can you elaborate which format you have in mind?
internal_tools/hw_decoder_bench.py
Outdated
| parser.add_argument( | ||
| "-j", | ||
| dest="num_threads", | ||
| help="CPU threads. Can be a single value (e.g. 4) or range 'start:end:step' (e.g. 1:8:2)", |
There was a problem hiding this comment.
I'd mention that the end of the range is included (which is not typically the case in Python ranges)
internal_tools/hw_decoder_bench.py
Outdated
| ) | ||
|
|
||
|
|
||
| def parse_range_arg(arg_str, use_float=False): |
There was a problem hiding this comment.
just a suggestion: maybe just parse_fn=int here instead of use_float
Signed-off-by: Janusz Lisiecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A