-
Notifications
You must be signed in to change notification settings - Fork 66
Bump based CUDA image to ubuntu24.04 #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d602ff3
Test docker hub ubuntu24.04
DwarKapex 7a93390
Adobt build for ubuntu-24.04
DwarKapex 3f4efa5
Fix build for pax, t5x, gemma
DwarKapex b2eab65
Use master branch of TF-text
DwarKapex 71ad68b
Fix gemma TF-text urls
DwarKapex 0b452c4
Fix T5x build
DwarKapex 62e7ed7
Address comments
DwarKapex beb4f82
Fix gemma build
DwarKapex 3c2ec97
Clone airio
DwarKapex d279373
Merge remote-tracking branch 'origin/main' into vkozlov/move-to-ubunt…
DwarKapex 173ddc5
Update maxtext docker
DwarKapex 92996e3
Uninstall several packages and add PIP_BREAK_SYSTEM_PACKAGES=1 env var
DwarKapex 8993deb
Uninstall several packages and add PIP_BREAK_SYSTEM_PACKAGES=1 env var
DwarKapex 8c10287
Edit remove packages list
DwarKapex c75c825
Edit remove packages list
DwarKapex 8468c9f
Edit remove packages list
DwarKapex 008b3fc
[skip ci] Resurect amd64/arm64 dockerfiles
DwarKapex d633578
[skip ci] Resurect amd64/arm64 dockerfiles: fix whitespace error
DwarKapex 81b50cc
[skip ci] Resurect amd64/arm64 dockerfiles: fix whitespace error
DwarKapex 14c52be
Merge branch 'main' into vkozlov/move-to-ubuntu24.04
DwarKapex 96c16a9
Add comment for pip install pip-23.3.1
DwarKapex 8461c7a
Merge branch 'vkozlov/move-to-ubuntu24.04' of github.com:NVIDIA/JAX-T…
DwarKapex 2c1ee0d
remove arch-specific Dockerfiles and add pointer to utopian versions
yhtang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # syntax=docker/dockerfile:1-labs | ||
| ARG BASE_IMAGE=nvidia/cuda:12.6.2-devel-ubuntu22.04 | ||
| ARG BASE_IMAGE=nvidia/cuda:12.6.2-devel-ubuntu24.04 | ||
| ARG GIT_USER_NAME="JAX Toolbox" | ||
| ARG [email protected] | ||
| ARG CLANG_VERSION=18 | ||
|
|
@@ -60,7 +60,8 @@ apt_packages=( | |
| wget | ||
| jq | ||
| # llvm.sh | ||
| lsb-release software-properties-common | ||
| lsb-release | ||
| software-properties-common | ||
| # GCP autoconfig | ||
| pciutils hwloc bind9-host | ||
| ) | ||
|
|
@@ -74,8 +75,6 @@ apt-get install -y ${apt_packages[@]} | |
|
|
||
| # Install LLVM/Clang | ||
| bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" -- ${CLANG_VERSION} | ||
| apt-get remove -y software-properties-common lsb-release | ||
| apt-get autoremove -y # removes python3-blinker which conflicts with pip-compile in JAX | ||
|
|
||
| # Make sure that clang and clang++ point to the new version. This list is based | ||
| # on the symlinks installed by the `clang` (as opposed to `clang-14`) and `lld` | ||
|
|
@@ -106,6 +105,21 @@ EOL | |
|
|
||
| apt-get clean | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # There are several python packages (in the list below) that are installed with OS | ||
| # package manager (the run of `apt-get install` above) and can not be uninstall | ||
| # using pip (in pip-finalize.sh script) during JAX installation. Remove then in | ||
| # advance to avoid JAX installation issue. | ||
| remove_packages=( | ||
| python3-gi | ||
| software-properties-common | ||
| lsb-release | ||
| python3-yaml | ||
| python3-pygments | ||
| ) | ||
|
|
||
| apt-get remove -y ${remove_packages[@]} | ||
| apt-get autoremove -y # removes python3-blinker which conflicts with pip-compile in JAX | ||
| EOF | ||
|
|
||
| RUN <<"EOF" bash -ex | ||
|
|
@@ -129,7 +143,14 @@ git apply </opt/pip/pip-vcs-equivalency.patch | |
| git add -u | ||
| git commit -m 'Adds JAX_TOOLBOX_VCS_EQUIVALENCY as a trigger to treat all github VCS installs for a package as equivalent. The spec of the last encountered version will be used' | ||
| EOF | ||
| RUN pip install --upgrade --no-cache-dir -e /opt/pip pip-tools && rm -rf ~/.cache/* | ||
|
|
||
| # install all python packages system-wide. | ||
| ENV PIP_BREAK_SYSTEM_PACKAGES=1 | ||
| # An extra flag `--ignore-installed` is added below, because of the following reason: | ||
| # after upgrading to ver 23.3.1 (from /opt/pip) `pip` tries to uninstall itself (default pip-24.0) | ||
| # and fails due to pip-24.0 has been installed with system tool `apt` but not `python`. So we keep | ||
| # both pip-24.0 and pip-23.3.1 in the system, but use 23.3.1 with equivalency patch (see above). | ||
| RUN pip install --upgrade --ignore-installed --no-cache-dir -e /opt/pip pip-tools && rm -rf ~/.cache/* | ||
|
|
||
| ############################################################################### | ||
| ## Install TCPx | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.