Remove deprecated flag xla_gpu_enable_triton_softmax_fusion. #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DwarKapex
approved these changes
Jan 10, 2025
|
@DwarKapex does the CI results tell we can merge? |
|
The flag was removed completely and will be causing failures: openxla/xla@e3ee51f |
olupton
approved these changes
Jan 21, 2025
Merging based on this. I do not think the CI here is sensitive to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
JAX-Toolbox/rosetta/docs/GPU_performance.md
Line 141 in 9dd32f5