-
Notifications
You must be signed in to change notification settings - Fork 66
Add GKE example #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add GKE example #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
reviewed
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The MaxText job hasn't run yet in the current pipeline, so I haven't checked the logs there, but posting a few comments.
Generally I'm in favour of merging this and refining later - it seems low-risk of breaking anything else.
…to alechan/gke-runner
olupton
approved these changes
Jul 3, 2025
aybchan
added a commit
that referenced
this pull request
Jul 15, 2025
Add `GKE` `MaxText` train ([example run](https://github.com/NVIDIA/JAX-Toolbox/actions/runs/15744603099/job/44379358307)) and `NCCL` test ([example run](https://github.com/NVIDIA/JAX-Toolbox/actions/runs/15744603099/job/44378422712)) workflows with reusable composite action for managing `xpk` job lifecycle (launch, logs streaming, clean up, artifact upload). Patches on `xpk` address the following identified issues: - AI-Hypercomputer/xpk#476 - AI-Hypercomputer/xpk#488 - AI-Hypercomputer/xpk#490 - AI-Hypercomputer/xpk#491 - AI-Hypercomputer/xpk#492 Cluster create with `xpk` ([example run](https://github.com/NVIDIA/JAX-Toolbox/actions/runs/15591134618/job/43910254644#step:5:1)) - added as a separate [workflow](https://github.com/NVIDIA/JAX-Toolbox/pull/1481/files#diff-801fc28cafbf1e0fa0ea521355fa8a1c9e6c01dcb8b1083c47f66e2ead4d560a) for demonstration purposes (will not be operational in the CI) --------- Co-authored-by: Olli Lupton <[email protected]>
aybchan
added a commit
that referenced
this pull request
Aug 11, 2025
Upgrades xpk version used in GKE-xpk action for running workloads from `v0.8.0` to `v0.10.1`. This latest release includes some fixes and feature requests that were [made](https://github.com/AI-Hypercomputer/xpk/issues?q=is%3Aissue%20state%3Aclosed%20author%3Aaybchan) based on issues with xpk found in previous work #1481 While the fixes address most of the issues found previously, we still need to add the following patches to use `v0.10.1` for running cluster workloads: - workload patch due to AI-Hypercomputer/xpk#577 - tcpxo_decorator patch due to container NCCL unavailability ([example](https://github.com/NVIDIA/JAX-Toolbox/actions/runs/16827982684/job/47671112135#step:7:1119)) without explicitly prepending path in `LD_LIBRARY_PATH` to override the default NCCL library from the host-mounted directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
GKEMaxTexttrain (example run) andNCCLtest (example run) workflows with reusable composite action for managingxpkjob lifecycle (launch, logs streaming, clean up, artifact upload).Patches on
xpkaddress the following identified issues:ServiceAccountis missing RBAC required for distributed JAX in Kubernetes AI-Hypercomputer/xpk#488JobSetspec fora3-megagpu-8gworkloads AI-Hypercomputer/xpk#492Cluster create with
xpk(example run) - added as a separate workflow for demonstration purposes (will not be operational in the CI)