Skip to content

Conversation

@olupton
Copy link
Collaborator

@olupton olupton commented Jun 2, 2025

The main feature added here is that a special directory, /triage-tool-output, is mounted into the container when the test case is executed, and the host-side versions of this directory are tracked by the tool so it can identify those corresponding to the last-known-good and first-known-bad invocations of the test case.

This means that the user can immediately examine "what changed", without having to manually re-run those two configurations.

Other minor changes:

  • Add a Container interface with PyxisContainer and DockerContainer implementations, for neater type annotations.
  • Add a result cache, which allows the tool to avoid some redundant re-executions
  • Write the same log information to info.log as to the console
  • Only call git fetch if needed; if commit-level triage is using a "new"/failing container, all relevant git history should already be available.

@olupton olupton requested a review from gspschmid June 2, 2025 14:37
gspschmid
gspschmid previously approved these changes Jun 3, 2025
Copy link
Contributor

@gspschmid gspschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

@olupton olupton merged commit 92243a8 into main Jun 4, 2025
91 of 93 checks passed
@olupton olupton deleted the olupton/triage-output branch June 4, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants