-
Notifications
You must be signed in to change notification settings - Fork 152
add security context support to binder pod #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@enoodle - would like some feedback on the approach. |
rich7420
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the patch!
A little suggestion: You've better develop on your other branch not main branch.
|
|
||
| if config.ResourceReservation.PodSecurityContext != nil { | ||
| secCtxJSON, err := json.Marshal(config.ResourceReservation.PodSecurityContext) | ||
| if err == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here should return some error message.
|
The implementation makes sense. I wonder if we can find a more structured way to pass the configuration to the reservation service. What do you think? Thanks! |
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Description
Related Issues
Fixes #570
Checklist
Breaking Changes
Additional Notes