Skip to content

Conversation

@AAnoosheh
Copy link
Contributor

What does this PR do ?

ModelOpt path still used model_provider without a builder function, so it's been updated to be synced with the standard code path.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@AAnoosheh AAnoosheh requested a review from jaredcasper November 3, 2025 14:45
@AAnoosheh AAnoosheh self-assigned this Nov 3, 2025
@AAnoosheh AAnoosheh requested a review from a team as a code owner November 3, 2025 14:45
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@AAnoosheh AAnoosheh added Run tests Expert Review Apply this label to indicate that your PR is ready for expert review. labels Nov 3, 2025
@kevalmorabia97 kevalmorabia97 changed the title Refactor model_provider to model_builder format Refactor model_provider to model_builder format for ModelOpt examples Nov 3, 2025
@AAnoosheh
Copy link
Contributor Author

/ok to test a1ad1f9

@ko3n1g ko3n1g added this to the Core 0.16 milestone Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expert Review Apply this label to indicate that your PR is ready for expert review. Run tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants