Skip to content

Conversation

@wplf
Copy link
Contributor

@wplf wplf commented Jan 6, 2026

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @megatron-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @megatron-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

ko3n1g and others added 30 commits September 24, 2025 11:00
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
…imizer

Co-authored-by: Zijie Yan <[email protected]>
Co-authored-by: Hao Wu <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Co-authored-by: Boxiang Wang <[email protected]>
Co-authored-by: mikail <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
…sing dsv3 tokenizer after !3646; Have datasets account for tokenizers which incorrectly define PAD;

Co-authored-by: Teodor-Dumitru Ene <[email protected]>
@wplf wplf requested review from a team as code owners January 6, 2026 03:26
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot requested a review from Phlip79 January 6, 2026 03:26
@wplf wplf changed the title Jinliang/hsdp ep Support EP with HSDP Jan 6, 2026
@wplf wplf marked this pull request as draft January 6, 2026 04:53
@wplf wplf force-pushed the jinliang/hsdp-ep branch from 4057404 to a7e1464 Compare January 6, 2026 06:51
@wplf wplf force-pushed the jinliang/hsdp-ep branch from a7e1464 to 1c448e7 Compare January 6, 2026 06:54
@wplf wplf force-pushed the jinliang/hsdp-ep branch from ec37d24 to 7b8f161 Compare January 9, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.