Add retry loop with exponential backoff in dataloader as a form of in-application fault tolerance #2836
+45
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepak Narayanan <[email protected]>
deepakn94
force-pushed
the
dnarayanan/dataloader_retry_loop
branch
from
323bdb9 to
84de5b2
Compare
kvareddy
approved these changes
Jan 7, 2026
jkamalu
requested changes
Jan 7, 2026
jkamalu
left a comment
jkamalu
left a comment
There was a problem hiding this comment.
Naming and scope of certain magic numbers and then some nits (which you can choose to ignore)
| bin_buffer_file.readinto(sequence) | ||
| return sequence | ||
|
|
||
| NUM_MAX_RETRIES = 3 |
There was a problem hiding this comment.
Why are these in all caps? Why don't we make these init args, or at least class args?
Contributor
Author
There was a problem hiding this comment.
Added, though I didn't thread the two new arguments through all the classes from the DatasetConfig class since I think that's overkill.
Signed-off-by: Deepak Narayanan <[email protected]>
deepakn94
force-pushed
the
dnarayanan/dataloader_retry_loop
branch
from
e736d65 to
332a0e9
Compare
jkamalu
approved these changes
Jan 9, 2026
ericharper
added
the
Final Review
ericharper
approved these changes
Jan 10, 2026
maanug-nv
pushed a commit
to maanug-nv/Megatron-LM
that referenced
this pull request
Jan 10, 2026
…-application fault tolerance (NVIDIA#2836) Signed-off-by: Deepak Narayanan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.