chore: remove nv-grouped-gemm dependency#3770
Open
liuyun7345 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
The deprecated GroupedMLP was removed in PR NVIDIA#3410, so the nv-grouped-gemm package is no longer needed. Changes: - Remove nv-grouped-gemm from dev and lts optional dependencies - Remove nv-grouped-gemm from uv no-build-isolation-package list - Remove grouped_gemm wheel build/install from Docker script Fixes NVIDIA#3711 Made-with: Cursor
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the
nv-grouped-gemmpackage dependency since the deprecatedGroupedMLPwas removed in PR #3410. The package is no longer usedanywhere in the codebase.
Changes
pyproject.toml: Removenv-grouped-gemmfromdevandltsoptional dependencies, and from
[tool.uv] no-build-isolation-packagedocker/common/install_source_wheels.sh: Removegrouped_gemmwheel build and installation logic (including the reference to the
non-existent
build_groupedgemm.shscript)Verification
import grouped_gemmorfrom grouped_gemm— the package has zero runtime usageTEGroupedMLPuses TransformerEngine'sGroupedLinearinternally,not
nv-grouped-gemm--moe-grouped-gemmCLI flag andmoe_grouped_gemmconfigfield remain unchanged (they control TE's grouped GEMM, not the
removed package)
Fixes #3711