Shanmugamr1992/megatron inference ultra#3784
Shanmugamr1992/megatron inference ultra#3784shanmugamr1992 wants to merge 57 commits intoNVIDIA:mainfrom
Conversation
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
/ok to test f71f013 |
wdykas
left a comment
wdykas
left a comment
There was a problem hiding this comment.
thanks for the annotation for helping refit.
|
|
||
| choices.append(choice_data) | ||
| if choice_data["generation_log_probs"] is None: | ||
| print(f"Generation log probs is None for request:\n{json.dumps(result, indent=4)}", flush=True) |
There was a problem hiding this comment.
Can we put this in a logging statement? Also does this indicate a bug?
There was a problem hiding this comment.
Done. Put this to loging
| # 'logprobs' in chat API is an object containing 'content' | ||
| # "logprobs": {"content": logprobs_content} if logprobs_content else None, |
There was a problem hiding this comment.
Can you remove these lines?
| assert "prompt_token_ids" in last_assistant_message and "generation_token_ids" in last_assistant_message, \ | ||
| "Last assistant message must have prompt_token_ids and generation_token_ids from previous generation to avoid prefix retokenization" |
There was a problem hiding this comment.
Nit: Can you split this into multiple lines?
svcnvidia-nemo-ci
added
Approved
|
/ok to test d43aeca |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22979974974 |
10 participants
What does this PR do ?
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.