Skip to content

Exposing interleave argument for fused_apply_rotary_pos_emb_thd#3794

Open
huvunvidia wants to merge 3 commits intoNVIDIA:mainfrom
huvunvidia:huvu/rope_fusion_thd_interleave_main
Open

Exposing interleave argument for fused_apply_rotary_pos_emb_thd#3794
huvunvidia wants to merge 3 commits intoNVIDIA:mainfrom
huvunvidia:huvu/rope_fusion_thd_interleave_main

Conversation

@huvunvidia
Copy link
Contributor

What does this PR do ?

Exposing interleave argument for fused_apply_rotary_pos_emb_thd.
This PR is the mirror of #3759.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@huvunvidia huvunvidia requested review from a team as code owners March 11, 2026 03:14
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 11, 2026 03:14
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 11, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 11, 2026
@Phlip79 Phlip79 marked this pull request as ready for review March 11, 2026 05:39
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 11, 2026 05:39
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Final Review PR is in the "final review" stage complexity: low labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants