Skip to content

Fix backward compatibility issue with MFSDP --grad-reduce-in-bf16#3799

Open
shjwudp wants to merge 2 commits intoNVIDIA:mainfrom
shjwudp:fix_mfsdp_bf16_grad_reduce
Open

Fix backward compatibility issue with MFSDP --grad-reduce-in-bf16#3799
shjwudp wants to merge 2 commits intoNVIDIA:mainfrom
shjwudp:fix_mfsdp_bf16_grad_reduce

Conversation

@shjwudp
Copy link
Contributor

@shjwudp shjwudp commented Mar 11, 2026

What does this PR do ?

In the Megatron-FSDP code path, the new flag --megatron-fsdp-grad-comm-dtype overrides the previous --grad-reduce-in-bf16 functionality. This patch restores the --grad-reduce-in-bf16 behavior for backward compatibility.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@shjwudp shjwudp requested a review from cspades March 11, 2026 10:01
@shjwudp shjwudp self-assigned this Mar 11, 2026
@shjwudp shjwudp added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. module: megatron-fsdp labels Mar 11, 2026
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 11, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 11, 2026 10:01
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@shjwudp
Copy link
Contributor Author

shjwudp commented Mar 11, 2026

/ok to test 15c2369

@shjwudp
Copy link
Contributor Author

shjwudp commented Mar 11, 2026

/claude review

@shjwudp shjwudp marked this pull request as ready for review March 11, 2026 10:03
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 11, 2026 10:04
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@shjwudp
Copy link
Contributor Author

shjwudp commented Mar 11, 2026

/ok to test a89014b

@Phlip79 Phlip79 removed the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants