Skip to content

[DEV] fix(megatron-fsdp): build expt_device_mesh only for MoE models#3832

Merged
yaox12 merged 4 commits intoNVIDIA:devfrom
xuwchen:fix_expt_device_mesh_dev
Mar 18, 2026
Merged

[DEV] fix(megatron-fsdp): build expt_device_mesh only for MoE models#3832
yaox12 merged 4 commits intoNVIDIA:devfrom
xuwchen:fix_expt_device_mesh_dev

Conversation

@xuwchen
Copy link
Contributor

@xuwchen xuwchen commented Mar 12, 2026

What does this PR do ?

main PR: #3831

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@xuwchen xuwchen requested review from a team as code owners March 12, 2026 13:25
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 12, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shjwudp
Copy link
Contributor

shjwudp commented Mar 13, 2026

/ok to test 7d6e862

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 13, 2026
@shjwudp shjwudp added module: megatron-fsdp dev branch Dev branch related issues and development labels Mar 13, 2026
@shjwudp shjwudp added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Mar 13, 2026
@xuwchen
Copy link
Contributor Author

xuwchen commented Mar 13, 2026

/ok to test e75359f

@yaox12 yaox12 added this pull request to the merge queue Mar 16, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23158792959

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2026
@yaox12 yaox12 enabled auto-merge March 17, 2026 21:17
@yaox12
Copy link
Member

yaox12 commented Mar 17, 2026

/ok to test 8279788

@yaox12 yaox12 added this pull request to the merge queue Mar 17, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23220933852

Merged via the queue into NVIDIA:dev with commit 7c3eea6 Mar 18, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. module: megatron-fsdp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants