[OMNIML-4671] synth_support#1476
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new YAML pipeline config ChangesEAGLE3 Speculative Decoding Pipeline Configuration
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/launcher/examples/Qwen/Qwen3-8B/step1_synth.yaml`:
- Line 35: The file ends without a trailing newline (yamlfmt/pre-commit failed)
— open the file containing the container:
nvcr.io/nvidia/tensorrt-llm/release:1.2.0 line (step1_synth.yaml) and add a
single newline character at the end of the file so the file terminates with a
newline; save and re-run the pre-commit/CI checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1d1ea7b1-e933-4ba5-b798-52cf90786db2
📒 Files selected for processing (1)
tools/launcher/examples/Qwen/Qwen3-8B/step1_synth.yaml
Agent-authored via pensieve-intern's synth_support stage on Epic OMNIML-4666. Faithful extraction of task_0 (data synthesis via TRT-LLM server) from hf_offline_eagle3.yaml's monolithic 4-task pipeline, renamed task_0 for the standalone step convention. Signed-off-by: Chenhan D. Yu <chenhany@nvidia.com> [ci-retrigger] previous run had a cancelled matrix variant (runner pre-emption, not a real test failure)
9c69dc2 to
b96cb4c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1476 +/- ##
==========================================
- Coverage 76.78% 76.78% -0.01%
==========================================
Files 473 473
Lines 51413 51413
==========================================
- Hits 39476 39475 -1
- Misses 11937 11938 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b96cb4c to
277bad1
Compare
Draft PR opened by pensieve-intern for OMNIML-4671.
Stage
synth_supportof EpicOMNIML-4666. The agent ran from the SPEC on the ticket description; review every change before marking ready.Always-draft is enforced — the bot never auto-merges.
Summary by CodeRabbit