Skip to content

Add allow self signed to edge simulator #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add allow self signed to edge simulator #3814

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce2da9b
Add allow self signed to edge simulator
YuanTingHsieh Oct 28, 2025
4c2de44
Merge branch 'main' into add_allow_self_signed_to_edge
chesterxgchen Nov 6, 2025
9dc364e
Update nvflare/edge/simulation/config.py
YuanTingHsieh Nov 6, 2025
7071ef2
Update nvflare/edge/simulation/feg_api.py
YuanTingHsieh Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nvflare/edge/simulation/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def load_class(class_path) -> Type:
class ConfigParser:
def __init__(self, config_file: str):
self.job_name = None
self.allow_self_signed = False
self.get_job_timeout = None
self.processor = None
self.endpoint = None
Expand Down Expand Up @@ -116,6 +117,9 @@ def parse(self, config_file: str):
check_positive_number("get_job_timeout", n)
self.get_job_timeout = n

n = config.get("allow_self_signed", False)
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allow_self_signed configuration value is not validated to ensure it's a boolean type. If a user provides a non-boolean value (e.g., a string like "true" or an integer like 1), it could lead to unexpected behavior. Add type validation using check_object_type(\"allow_self_signed\", n, bool) after retrieving the value, similar to how other configuration values are validated in this method.

Suggested change
n = config.get("allow_self_signed", False)
n = config.get("allow_self_signed", False)
check_object_type("allow_self_signed", n, bool)

Copilot uses AI. Check for mistakes.
self.allow_self_signed = n

def _variable_substitution(self, args: Any, variables: dict) -> Any:
if isinstance(args, dict):
return {k: self._variable_substitution(v, variables) for k, v in args.items()}
Expand Down
7 changes: 5 additions & 2 deletions nvflare/edge/simulation/feg_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@


class FegApi:
def __init__(self, endpoint: str, device_info: DeviceInfo, user_info: UserInfo):
def __init__(self, endpoint: str, device_info: DeviceInfo, user_info: UserInfo, allow_self_signed: bool = False):
self.endpoint = endpoint
self.device_info = device_info
self.user_info = user_info
Expand All @@ -46,6 +46,7 @@ def __init__(self, endpoint: str, device_info: DeviceInfo, user_info: UserInfo):
HttpHeaderKey.DEVICE_INFO: device_qs,
HttpHeaderKey.USER_INFO: user_qs,
}
self.allow_self_signed = allow_self_signed

def get_job(self, request: JobRequest) -> JobResponse:
return self._do_post(
Expand Down Expand Up @@ -91,7 +92,9 @@ def get_selection(self, request: SelectionRequest) -> SelectionResponse:
)

def _do_post(self, clazz, url, params, body):
response = requests.post(url, params=params, json=body, headers=self.common_headers)
response = requests.post(
url, params=params, json=body, headers=self.common_headers, verify=False if self.allow_self_signed else True
)
Comment on lines 98 to 100
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When verify=False is used with requests.post(), it triggers InsecureRequestWarning from urllib3. These warnings should be suppressed when allow_self_signed is True to avoid cluttering logs. Add import urllib3 at the top of the file and call urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) in the __init__ method when allow_self_signed is True.

Copilot uses AI. Check for mistakes.
code = response.status_code
if code == 200:
return clazz(**response.json())
Expand Down
1 change: 1 addition & 0 deletions nvflare/edge/simulation/run_device_simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def _send_request_to_proxy(request, device: SimulatedDevice, parser: ConfigParse
endpoint=parser.get_endpoint(),
device_info=device.get_device_info(),
user_info=device.get_user_info(),
allow_self_signed=parser.allow_self_signed,
)
if isinstance(request, TaskRequest):
return api.get_task(request)
Expand Down
Loading