chore: implement image copy to gcp using oidc#265
Closed
mchmarny wants to merge 13 commits intoNVIDIA:mainfrom
Closed
chore: implement image copy to gcp using oidc#265mchmarny wants to merge 13 commits intoNVIDIA:mainfrom
mchmarny wants to merge 13 commits intoNVIDIA:mainfrom
Conversation
The || { ... } syntax was causing a syntax error with set -euo pipefail.
Changed to standard if-then-fi structure for better compatibility.
Signed-off-by: Mark Chmarny <mchmarny@nvidia.com>
Signed-off-by: Mark Chmarny <mchmarny@nvidia.com>
Signed-off-by: Mark Chmarny <mchmarny@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP: validation of secretless connection to GCP using OIDC. For now just copies images from GHCR for a given tag but eventually we want to use this to bring up integration cluster and do full e2e tests in the target CSP.
Type of Change
Component(s) Affected
Testing
Checklist