Forward-merge release/0.8 into main - #945
Merged
Merged
Conversation
#### Overview Make coding-agent uninstallation resilient when Relay configuration or persisted installation state is malformed, and provide a force-enabled escape hatch. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Keep uninstall logging independent of ambient Relay configuration while still validating direct logging inputs. - Add `--force` to `uninstall codex`, `uninstall claude-code`, and `uninstall all`, so Relay-owned setup, host registration, marketplace, and deterministic local-state cleanup are attempted independently. - Add regression coverage for malformed ambient and explicit logging configuration, stale local installations, and cleanup after setup failures. - Document the force cleanup escape hatch for the coding-agent integrations. #### Where should the reviewer start? Start with `crates/cli/src/installation/marketplace/mod.rs`, which defines the force cleanup behavior and its error aggregation. Then review the command logging policy in `crates/cli/src/commands/mod.rs`. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: [RELAY-805](https://linear.app/nvidia/issue/RELAY-805/ensure-uninstall-all-does-not-load-malformed-relay-configuration) ## Summary by CodeRabbit * **New Features** * Added `--force` support for uninstalling integrations when stale installation data blocks normal removal. * Forced uninstall independently attempts cleanup of settings, registrations, marketplace data, and local installation state, reporting incomplete steps. * Improved detection of locally installed integrations during forced operations. * **Bug Fixes** * Uninstall now handles malformed ambient logging configuration without failing unnecessarily. * **Documentation** * Documented forced-uninstall behavior, cleanup results, and recovery steps for supported coding-agent integrations. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Maryam Najafian (https://github.com/mnajafian-nv) - Eric Evans II (https://github.com/ericevans-nv) URL: #942
Author
|
SUCCESS - forward-merge complete. |
github-actions
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.8 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.