harness: add inherited presets and auto worker sizing#1539
Open
jioffe502 wants to merge 4 commits intoNVIDIA:mainfrom
Open
harness: add inherited presets and auto worker sizing#1539jioffe502 wants to merge 4 commits intoNVIDIA:mainfrom
jioffe502 wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
- add preset inheritance to reduce duplicated harness tuning - limit auto mode to worker counts and document the user story - wire harness tuning into batch requested plan refreshes Signed-off-by: Jacob Ioffe <jioffe@nvidia.com>
jdye64
requested changes
Mar 10, 2026
| return {key: value for key, value in env_vars.items() if isinstance(value, str)} | ||
|
|
||
|
|
||
| def _normalize_requested_plan_int(value: Any) -> int | None: |
Collaborator
There was a problem hiding this comment.
What purpose do these added functions in batch.py serve? Can we move them elsewhere?
| self._extract_html_kwargs: Dict[str, Any] = {} # noqa: F821 | ||
| self._use_nemotron_parse_only: bool = False | ||
|
|
||
| def _refresh_requested_plan(self, batch_tuning: dict[str, Any]) -> None: |
Collaborator
There was a problem hiding this comment.
I think most of this can already be accomplished with the existing functions in ray_resource_hueristics.py but if they are needed for some reason lets move them there and name them appropriately not not clutter the core logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist