Merged
Conversation
… into fix-lance-slim
… into fix-lance-slim
jioffe502
approved these changes
Mar 11, 2026
| local_hf_cache_dir: Optional[Path] = None | ||
| local_hf_batch_size: int = 64 | ||
| # Reranking ----------------------------------------------------------- | ||
| reranker: Optional[str] = "nvidia/llama-nemotron-rerank-1b-v2" |
Collaborator
There was a problem hiding this comment.
The default here is the model name, which means any code that creates a Retriever() without explicitly setting reranker will download and load the 1B model. The docstring on line 58 says "Set to None to skip reranking (default)"
should this default to None instead so reranking is opt-in?
The batch_pipeline.py handles this correctly with the --reranker bool flag
this is just about the dataclass default for direct Retriever() callers.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds reranker to be used in batch example. Also fixed recall to work with the retriever object to get queries.
Checklist