(patch) clarify baseline vs effective embed config in logs#1782
Open
jioffe502 wants to merge 1 commit intoNVIDIA:mainfrom
Open
(patch) clarify baseline vs effective embed config in logs#1782jioffe502 wants to merge 1 commit intoNVIDIA:mainfrom
jioffe502 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Log BaselineRequestedPlan before overrides and EffectiveEmbedConfig after graph node overrides resolve, so harness/CLI tuning is not mistaken for the heuristic RequestedPlan snapshot. Signed-off-by: jioffe502 <jioffe@nvidia.com>
jperez999
requested changes
Apr 3, 2026
Collaborator
jperez999
left a comment
jperez999
left a comment
There was a problem hiding this comment.
This file no longer exists in the code base nor should it come back. Do we need these changes perhaps in graph_ingestor or maybe in the graph_pipeline.py?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log BaselineRequestedPlan before overrides and EffectiveEmbedConfig after graph node overrides resolve, so harness/CLI tuning is not mistaken for the heuristic RequestedPlan snapshot.
During testing I noticed that explicit harness/CLI embed overrides did not appear in the initial RequestedPlan log—that snapshot is from cluster heuristics before overrides. The subprocess command was correct, but the logs were misleading.
This PR labels that line as baseline-only and logs the effective embed actor count, batch size, and GPU fraction once overrides are applied.
Checklist