Skip to content

(retriever) raise clear error when libreoffice is missing for DOCX/PPTX conversion#1791

Merged
edknv merged 1 commit intoNVIDIA:mainfrom
edknv:edwardk/retriever-libreoffice-fail-fast
Apr 3, 2026
Merged

(retriever) raise clear error when libreoffice is missing for DOCX/PPTX conversion#1791
edknv merged 1 commit intoNVIDIA:mainfrom
edknv:edwardk/retriever-libreoffice-fail-fast

Conversation

@edknv
Copy link
Copy Markdown
Collaborator

@edknv edknv commented Apr 3, 2026

Description

Previously FileNotFoundError was getting swallowed silently in batch pipeline when LibreOffice was missing. This PR raises error loudly in batch mode when LibreOffice is missing in docx/pptx extraction.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

@edknv edknv requested review from a team as code owners April 3, 2026 01:47
@edknv edknv requested a review from charlesbluca April 3, 2026 01:47
@edknv edknv merged commit 813b42a into NVIDIA:main Apr 3, 2026
6 of 7 checks passed
@edknv edknv deleted the edwardk/retriever-libreoffice-fail-fast branch April 3, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants