Skip to content

Move libsox-fmt-all from Dockerfile.ci.export_deploy to Dockerfile.ci #13452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chtruong814
Copy link
Collaborator

What does this PR do ?

Move libsox-fmt-all from Dockerfile.ci.export_deploy to Dockerfile.speech.

Thanks for @erastorgueva-nv for debugging this. It seems the issue was that the libsox-fmt-all package was not included in the new Dockerfile.speech when we split-up the repo builds and tests. We included it in the export tests. So, this caused the failure in L2_Segmentation_Tool_Parallel_ctc_segmentation_test_L2_Ru_QN_with_mp3.

Collection: [Note which collection this PR will affect]

Changelog

  • Move libsox-fmt-all from Dockerfile.ci.export_deploy to Dockerfile.speech

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@ko3n1g
Copy link
Collaborator

ko3n1g commented May 6, 2025

Thanks a lot! One correction: speech doesn’t actually use the speech container, so far it uses the same CI container as NeMo2 does

Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels May 6, 2025
@ko3n1g ko3n1g changed the title Move libsox-fmt-all from Dockerfile.ci.export_deploy to Dockerfile.speech Move libsox-fmt-all from Dockerfile.ci.export_deploy to Dockerfile.ci May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants