build(pkg): adopt npm workspaces for repository source packages - #10520
build(pkg): adopt npm workspaces for repository source packages#10520HOYALIM wants to merge 2 commits into
Conversation
Signed-off-by: Ho Lim <subhoya@gmail.com>
Signed-off-by: Ho Lim <subhoya@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe root project adds Changesnpm workspace integration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR updates package workspace configuration and lockfiles while preserving the existing standalone lockfile; repository checks, type checking, linting, and workspace linking pass, so no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR Review Advisor finished for commit |
|
✨ Thanks for the packaging work. This PR adopts npm workspaces for the repository source packages and passes all checks. Ready for maintainer review. |
Description
This pull request implements the second preparation step recommended in Discussion #9909 (RFC 0002) by organizing repository source packages under
npm workspaces.Key Changes
"workspaces": ["nemoclaw"]\ costumes to the rootpackage.json`.nemoclaw-plugin.package-lock.jsonwith the workspace configuration.Verification
npm run checks:repositorypassed with 0 errors.npm run typecheck:clipassed with 0 errors.npm run lintpassed with 0 errors.node_modules.Signed-off-by: Ho Lim subhoya@gmail.com
Summary by CodeRabbit