Skip to content

fix(e2e): select Pi qualification for image inputs - #10523

Open
cjagwani wants to merge 1 commit into
mainfrom
codex/fix-pi-source-ownership
Open

fix(e2e): select Pi qualification for image inputs#10523
cjagwani wants to merge 1 commit into
mainfrom
codex/fix-pi-source-ownership

Conversation

@cjagwani

@cjagwani cjagwani commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Outcome

Changes to any checked-in source copied by the Pi Dockerfiles now select both AMD64 and ARM64 Pi qualification targets. A regression test reads the real Dockerfiles, so a future COPY input cannot silently reuse a stale candidate image receipt without selecting Pi validation.

Reason

Both Pi jobs in main E2E run 33111284865 rejected a stale image receipt after nemoclaw-blueprint/scripts/nemotron-inference-fix.js changed. The Pi targets only owned agents/pi/, so that copied blueprint source did not select either Pi qualification job on the introducing PR.

Related issues

Part of #10153

Relates to #10390

Changes

  • Add the current Docker COPY inputs to the shared Pi target ownership boundary.
  • Apply that boundary to both pi-agent-qualification-amd64 and pi-agent-qualification-arm64.
  • Verify every real Pi Docker image source is owned by both targets.
  • Verify the blueprint source that exposed this gap selects both targets.

Verification

  • npx vitest run --project e2e-support test/e2e/support/pi-agent-qualification-events.test.ts — 11 tests passed after rebasing onto current origin/main.
  • npm run check:diff — passed, including repository checks, codebase growth guardrails, commitlint, and CLI TypeScript.
  • Normal pre-push hook — CLI TypeScript passed.
  • Documentation writer review — no docs changes needed because this only changes internal E2E target selection.
  • GitHub commit verification — the single commit is Verified with reason valid.
  • Diff inspection — no secrets, API keys, or credentials are present.

Review notes

This is complementary to #10390. That PR refreshes the Pi qualification receipts and runtime assertions; this PR adds the missing source-to-target selection boundary that allowed those receipts to become stale. If #10390 lands first, the shared support-test change may need a mechanical rebase.


Signed-off-by: Charan Jagwani cjagwani@nvidia.com

Summary by CodeRabbit

  • Bug Fixes

    • Improved Raspberry Pi image qualification to correctly recognize all files included in Docker image builds.
    • Ensured copied blueprint sources select the appropriate architecture-specific qualification targets.
  • Tests

    • Added end-to-end coverage to verify image source ownership and architecture-specific target selection.

Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
@cjagwani cjagwani self-assigned this Aug 27, 2026
@github-code-quality

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit ae63bb9 in the codex/fix-pi-source-... branch remains at 96%, unchanged from commit d0d5120 in the main branch.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 30b85fab-946b-47df-bb55-b45e7f429761

📥 Commits

Reviewing files that changed from the base of the PR and between d0d5120 and ae63bb9.

📒 Files selected for processing (2)
  • test/e2e/support/pi-agent-qualification-events.test.ts
  • tools/e2e/target-catalogue.mts

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Pi qualification targets now own all files copied into Pi Docker images. End-to-end tests validate Dockerfile source ownership and confirm that copied Nemotron blueprint changes select both architecture-specific targets.

Changes

Pi image ownership

Layer / File(s) Summary
Define and wire Pi image ownership
tools/e2e/target-catalogue.mts
The catalogue defines shared ownership for Pi Dockerfile inputs and applies it to both AMD64 and ARM64 qualification targets.
Validate ownership and target selection
test/e2e/support/pi-agent-qualification-events.test.ts
Tests verify Dockerfile source ownership for both targets and confirm that copied Nemotron blueprint changes select both targets.

Estimated code review effort: 2 (Simple) | ~15 minutes

Merge Risk: ⚪ Minimal · up to ae63b

This PR narrowly updates Pi qualification ownership and adds regression coverage for the Dockerfile inputs; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: brandonpelfrey

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: Pi qualification targets now select correctly for Docker image inputs.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-pi-source-ownership

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit ae63bb9. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs

@rsliter rsliter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking sequencing note: #10390 removes derivePiImageSourcePaths and moves Pi source parsing to the canonical directDockerfileCopySources helper. If #10390 lands first, rebase this PR and preserve its two new target-ownership assertions using that helper. I am not approving this revision because the required checks gate fails in CLI shards 8 and 10. The failures appear outside this PR’s changed paths: shard 8 failed with spawn node ENOENT in e2e-fixture-context.test.ts, and shard 10 timed out in profile-list.test.ts.

@wscurran wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure bug-fix PR fixes a bug or regression labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure bug-fix PR fixes a bug or regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants