fix(sandbox): verify descriptor routes without Ollama recovery

[senthilr-nv]

Outcome

Hermes Portable probe-only connections now recover published inference only for ollama-local. Descriptor-backed providers keep their existing verification-only route and no longer require an Ollama receipt.

Reason

The merged Hermes Portable recovery path sent every probe-only provider through Ollama recovery. A compatible-endpoint registry entry intentionally has no host-local Ollama receipt, so the route failed before its descriptor verification began.

Related issues

Follow-up to #10505.

Changes

• Dispatch Hermes Portable probe-only inference by the exact configured provider.
• Keep ollama-local on the published-runtime recovery path and preserve fail-closed missing or malformed receipt handling.
• Keep descriptor-backed providers and interactive launch on the existing verification-only path.
• Add regressions for descriptor verification without Ollama recovery and invalid Ollama receipts before registry mutation.

Verification

• Focused owner tests — 2 files and 38 tests passed.
• Focused connect composition — 3 files and 98 tests passed.
• npm run test:changed — 32 growth checks and 10 files / 130 affected tests passed.
• npm run checks:repository — passed.
• npm run build:cli — passed.
• npm run typecheck:cli — passed.
• Normal pre-commit, commit-message, and pre-push hooks — passed.
• GitHub reports commit 2a193d0139108b88e8a10c661599255e11bba01c as Verified with reason valid.
• The diff contains no secrets, API keys, or credentials.

Review notes

Independent review approved the exact frozen three-file snapshot. Merge remains held for one exact descriptor-backed Hermes Portable field probe on this commit.

---

Signed-off-by: Senthil Ravichandran senthilr@nvidia.com

Summary by CodeRabbit

• Bug Fixes

  • Improved Hermes Portable connection handling for compatible inference endpoints.
  • Added more reliable readiness checks for inference routing and sandbox launch behavior.
  • Restricted automatic recovery to supported local Ollama connections.
  • Invalid or incomplete Ollama recovery information is now rejected before recovery begins.

• Tests

  • Added coverage for successful endpoint routing and invalid recovery scenarios.

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 2a193d0 in the codex/hermes-descrip... branch remains at 96%, unchanged from commit b6ee5c8 in the main branch.

TypeScript / code-coverage/cli

The overall line coverage in commit 2a193d0 in the codex/hermes-descrip... branch remains at 84%, unchanged from commit b6ee5c8 in the main branch.

---

_{Updated August 28, 2026 15:53 UTC}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b7e00055-a483-4f67-9f15-90a50dc7eb19

📥 Commits

Reviewing files that changed from the base of the PR and between b6ee5c8 and 2a193d0.

📒 Files selected for processing (3)

• src/lib/actions/sandbox/connect-hermes-portable-inference-recovery-errors.test.ts
• src/lib/actions/sandbox/connect.ts
• src/lib/onboard/experimental/hermes-portable-ollama-recovery.test.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Hermes Portable connect and probe flows now verify non-Ollama routes directly and recover only Ollama routes. Tests cover compatible endpoint execution and validation failures for missing or malformed Ollama inference receipts.

Changes

Hermes Portable routing

Layer / File(s)	Summary
Conditional route verification and recovery src/lib/actions/sandbox/connect.ts	Probe-only connect and launch-readiness validation use conditional route verification. Non-ollama-local providers skip runtime recovery.
Route and recovery validation src/lib/actions/sandbox/connect-hermes-portable-inference-recovery-errors.test.ts, src/lib/onboard/experimental/hermes-portable-ollama-recovery.test.ts	Tests cover compatible-endpoint inference routing and reject missing or malformed hostLocalInferenceReceipt values before registry recovery.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🟡 Moderate · up to 2a193

The localized routing change preserves Ollama recovery while allowing descriptor-backed providers to verify without an Ollama receipt, and the listed automated checks pass. Merge should wait for the one outstanding descriptor-backed Hermes Portable field probe.

Suggested reviewers: apurvvkumaria

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: verifying descriptor routes without triggering Ollama recovery.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/hermes-descriptor-probe-dispatch

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

PR Review Advisor finished for commit 2a193d0. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs