fix(advisor): avoid nested context mount - #10731
Merged
Merged
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 900eecd in the TypeScript / code-coverage/cliThe overall line coverage in commit 900eecd in the Show a line coverage summary of the most impacted files.
Updated |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
PR Review Advisor specialist sandboxes can provision their immutable context without a nested bind mount beneath the read-only PR worktree.
Reason
The specialist-only refactor mounted prepared context at /pr-workdir/.pr-review-advisor-context after /pr-workdir had already been mounted read-only. Docker could not create the nested mountpoint and rejected sandbox startup.
Changes
Verification
Signed-off-by: Carlos Villela cvillela@nvidia.com