Skip to content

Fix authz sidecar evaluating tokens #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyaliNvidia merged 1 commit into from
Mar 11, 2026
Merged

Fix authz sidecar evaluating tokens #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/service/authz_sidecar/server/authz_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ const (
// Header names
headerOsmoUser = "x-osmo-user"
headerOsmoRoles = "x-osmo-roles"
headerOsmoTokenName = "x-osmo-token-name"
headerOsmoWorkflowID = "x-osmo-workflow-id"
headerOsmoAllowedPools = "x-osmo-allowed-pools"

// Default role added to all users
Expand Down Expand Up @@ -134,9 +136,11 @@ func (s *AuthzServer) Check(ctx context.Context, req *envoy_service_auth_v3.Chec
method := httpAttrs.GetMethod()
headers := httpAttrs.GetHeaders()

// Extract user and roles from headers
// Extract user, roles, and token/workflow identifiers from headers
user := headers[headerOsmoUser]
rolesHeader := headers[headerOsmoRoles]
tokenName := headers[headerOsmoTokenName]
workflowID := headers[headerOsmoWorkflowID]

// Parse roles (comma-separated)
var roleNames []string
Expand All @@ -153,7 +157,9 @@ func (s *AuthzServer) Check(ctx context.Context, req *envoy_service_auth_v3.Chec
// complete set of assigned OSMO roles in a single atomic operation.
// This maps external role names (from the JWT) to OSMO roles via
// role_external_mappings and applies sync_mode logic (import/force).
if user != "" {
// Skip sync for access tokens and workflow-originated requests, as their
// roles are already resolved from the access_token_roles table.
if user != "" && tokenName == "" && workflowID == "" {
dbRoleNames, err := roles.SyncUserRoles(ctx, s.pgClient, user, roleNames, s.logger)
if err != nil {
s.logger.Error("failed to sync user roles",
Expand All @@ -173,6 +179,8 @@ func (s *AuthzServer) Check(ctx context.Context, req *envoy_service_auth_v3.Chec
slog.String("user", user),
slog.String("path", path),
slog.String("method", method),
slog.String("token_name", tokenName),
slog.String("workflow_id", workflowID),
slog.Any("roles", roleNames),
)

Expand All @@ -181,6 +189,8 @@ func (s *AuthzServer) Check(ctx context.Context, req *envoy_service_auth_v3.Chec
if err != nil {
s.logger.Error("error resolving roles",
slog.String("user", user),
slog.String("token_name", tokenName),
slog.String("workflow_id", workflowID),
slog.String("error", err.Error()),
slog.Any("roles", roleNames),
)
Expand All @@ -199,6 +209,8 @@ func (s *AuthzServer) Check(ctx context.Context, req *envoy_service_auth_v3.Chec
slog.String("user", user),
slog.String("path", path),
slog.String("method", method),
slog.String("token_name", tokenName),
slog.String("workflow_id", workflowID),
slog.Any("roles", roleNames),
slog.Duration("parse", parseDone.Sub(checkStart)),
slog.Duration("sync_roles", syncDone.Sub(parseDone)),
Expand All @@ -213,6 +225,8 @@ func (s *AuthzServer) Check(ctx context.Context, req *envoy_service_auth_v3.Chec
slog.String("user", user),
slog.String("path", path),
slog.String("method", method),
slog.String("token_name", tokenName),
slog.String("workflow_id", workflowID),
)

responseHeaders := map[string]string{}
Expand All @@ -229,6 +243,8 @@ func (s *AuthzServer) Check(ctx context.Context, req *envoy_service_auth_v3.Chec
slog.String("user", user),
slog.String("path", path),
slog.String("method", method),
slog.String("token_name", tokenName),
slog.String("workflow_id", workflowID),
slog.Duration("parse", parseDone.Sub(checkStart)),
slog.Duration("sync_roles", syncDone.Sub(parseDone)),
slog.Duration("resolve_roles", resolveDone.Sub(syncDone)),
Expand Down
Loading