This repository was archived by the owner on Aug 3, 2021. It is now read-only.
emulate_multibleu was removed in NLTK #535
Open
cliffwoolley wants to merge 1 commit intoNVIDIA:masterfrom
Open
emulate_multibleu was removed in NLTK #535cliffwoolley wants to merge 1 commit intoNVIDIA:masterfrom
cliffwoolley wants to merge 1 commit intoNVIDIA:masterfrom
Conversation
…49ea37f3f8480d6734bd475b Signed-off-by: Cliff Woolley <jwoolley@nvidia.com>
cliffwoolley
force-pushed
the
jwoolley/remove-deprecated-nltk-flag
branch
from
bada556 to
8f040a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nltk/nltk@764dc8f#diff-de624b4549ea37f3f8480d6734bd475b
Based on sgrvinod/a-PyTorch-Tutorial-to-Image-Captioning#19 (comment) it looks like emulate_multibleu is basically the default now. I verified that removing this parameter lets our CI test pass. (It does not, however, deal with backward compatibility to older NLTK; if that's required, I leave it to you all.)