test(snap): smoke PR artifacts before release by elezar · Pull Request #2869 · NVIDIA/OpenShell

elezar · 2026-08-21T10:26:16Z

Summary

Exercise the Snap gateway lifecycle directly in PR CI using the already-built amd64 E2E binaries, without a Release Dev publish.

Related Issue

Related to #2055.

Changes

Extract credential-free Snap packaging for reusable release and PR paths.
Add the test:snap PR label, fresh-runner Snap smoke test, readiness bound, and diagnostic journals.
Reuse the same smoke action from Release Canary.

Testing

mise run pre-commit passes
actionlint passes after excluding the repository's known custom runner-label warnings
GitHub Actions test:snap run

Checklist

Follows Conventional Commits
Commits are signed off (DCO)

elezar · 2026-08-21T10:41:54Z

/ok-to-test d96c61a

johntmyers

gator-agent

PR Review Status

This project-valid Snap CI refactor has one blocking revision-coupling defect in Release Canary. The current-head Branch Checks, Helm Lint, and Snap Smoke are green, but the supported older-branch Release Dev path can fail before testing its artifact.

Action required: keep the executing canary workflow's repository revision checked out when loading the new local action, then push an update.

Blocking findings:

GATOR-0843e094-01: Release Canary can load the local smoke action from an artifact-producing revision that predates the action.

Carried findings:

None

Non-blocking suggestions:

Add test:snap to the opt-in test-label enumeration in CONTRIBUTING.md.

Gator metadata

Validation: Maintainer-authored CI/release improvement tied to the Snap gateway lifecycle work in #2055
Docs: CI.md and the release-canary skill are updated; CONTRIBUTING.md label discovery has a non-blocking omission
Checks: Current-head required checks are green
E2E: test:snap is applied and Snap Smoke passed for the current head
Head SHA: 0843e09412d63b951104f0562c99891db51df7f4
Base SHA: 0fce474c127057164e477111256fd2ceaa866a08
Merge base SHA: 0fce474c127057164e477111256fd2ceaa866a08
Patch ID: c48874d272e4b1f04374369f6990d77488e1e320
Gator payload: 7
Review mode: initial
Previous reviewed SHA: none
Review budget exhausted: no
Maintainer decision required: no
Next state: gator:in-review

johntmyers

gator-agent

Re-check After Author Update

Thanks @elezar. I reviewed the new author-only delta: the Release Canary checkout now stays on the executing workflow revision while the existing run ID continues to select the Snap artifact, so GATOR-0843e094-01 is resolved. I also confirmed the test:snap documentation link was added to CONTRIBUTING.md. No blocking findings remain.

Current-head Branch Checks and the test:snap Branch E2E workflow are running, so Gator is moving to pipeline monitoring.

Blocking findings:

None

Carried findings:

None

Gator metadata

Validation: Maintainer-authored CI/release improvement tied to the Snap gateway lifecycle work in #2055
Docs: CI.md, the release-canary skill, and CONTRIBUTING.md cover the new Snap test path
Checks: Current-head required checks are queued or running; DCO and Helm Lint are green
E2E: test:snap is applied; current-head Branch E2E run 32970119053 is in progress
Head SHA: 2d6b888d9bcf2ed43676a22be72dff5bee9c8dbe
Base SHA: d3a417e422ba9830bf43402b2f008473be1da2b4
Merge base SHA: d3a417e422ba9830bf43402b2f008473be1da2b4
Patch ID: b541e60bd66472f2d7e0fda03d36443e4a79a1e5
Gator payload: 7
Review mode: follow_up
Previous reviewed SHA: 0843e09412d63b951104f0562c99891db51df7f4
Review budget exhausted: no
Maintainer decision required: no
Next state: gator:watch-pipeline

+      - name: Prepare snap build directory
+        run: |
+          set -euo pipefail
+          case "${{ inputs.artifact-layout }}" in


+              ;;
+            raw) ;;
+            *)
+              echo "unsupported artifact layout: ${{ inputs.artifact-layout }}" >&2


johntmyers · 2026-08-27T14:26:02Z

/ok to test 215657c

johntmyers

gator-agent

Re-check After Author Update

Thanks @elezar. I reviewed the author-only range-diff from 2d6b888d9bcf2ed43676a22be72dff5bee9c8dbe to the current head. The rebase integration updates only the PR's CI.md context to match its new base, while the canary checkout fix remains unchanged, so GATOR-0843e094-01 stays resolved. No blocking findings remain.

Current-head Branch Checks and Branch E2E are running after runner validation for this SHA, so Gator is returning to pipeline monitoring.

Blocking findings:

None

Carried findings:

None

Gator metadata

Validation: Maintainer-authored CI/release improvement tied to the Snap gateway lifecycle work in #2055
Docs: CI.md, the release-canary skill, and CONTRIBUTING.md cover the Snap test path
Checks: Current-head Branch Checks and Branch E2E are in progress; Helm Lint is green
E2E: test:e2e and test:snap are applied; current-head Branch E2E run 33082214244 is in progress
Head SHA: 215657ced18ae544ef5b7cc6b1b4449a5317d0b4
Base SHA: 68c9584c2fdbef8acf5cda2735fb6b396641432b
Merge base SHA: 68c9584c2fdbef8acf5cda2735fb6b396641432b
Patch ID: 13a18968bbabb24162fd542d393b5a2cfef26f96
Gator payload: 7
Review mode: follow_up
Previous reviewed SHA: 2d6b888d9bcf2ed43676a22be72dff5bee9c8dbe
Review budget exhausted: no
Maintainer decision required: no
Next state: gator:watch-pipeline

johntmyers

gator-agent

Re-check After Author Update

Thanks @elezar. I reviewed the author-only integration delta at the latest head in critical-only mode. The Release Canary checkout still uses the executing workflow revision, so GATOR-0843e094-01 remains resolved, and the integration with the newer binary-build workflows introduces no new Critical defect. No blocking findings remain.

Current-head Branch Checks and Helm Lint are green, and Branch E2E—including Snap Smoke—is running, so Gator is returning to pipeline monitoring.

Blocking findings:

None

Carried findings:

None

Gator metadata

Validation: Maintainer-authored CI/release improvement tied to the Snap gateway lifecycle work in #2055
Docs: CI.md, the release-canary skill, and CONTRIBUTING.md cover the Snap test path
Checks: Current-head Branch Checks and Helm Lint are green; Branch E2E is in progress
E2E: test:e2e and test:snap are applied; current-head run 33406489287 is in progress
Head SHA: 4ed5fb9a7b4fa24d220edba68377badf9bbd46e5
Base SHA: 9fdcd52932e7dbe922abbe3280500ce1eb139ebe
Merge base SHA: 9fdcd52932e7dbe922abbe3280500ce1eb139ebe
Patch ID: db623e23e01bc28509f4118c1df2801e77c4c194
Gator payload: 7
Review mode: critical_only
Previous reviewed SHA: 215657ced18ae544ef5b7cc6b1b4449a5317d0b4
Review budget exhausted: yes
Maintainer decision required: no
Next state: gator:watch-pipeline

johntmyers · 2026-09-01T09:16:09Z

/ok to test 4ed5fb9

Signed-off-by: Evan Lezar <elezar@nvidia.com>

johntmyers

gator-agent

Re-check After Author Update

Thanks @elezar. I reviewed the author-only integration delta from 4ed5fb9a7b4fa24d220edba68377badf9bbd46e5 to the current head in critical-only mode. The delta adds the now-required build-conformance dependency to docker-e2e; it does not invalidate the Release Canary checkout fix for GATOR-0843e094-01 and introduces no new Critical defect. No blocking findings remain.

Current-head Branch Checks and Branch E2E, including the Snap build/smoke path selected by test:e2e and test:snap, are queued or running, so Gator is returning to pipeline monitoring.

Blocking findings:

None

Carried findings:

None

Gator metadata

Validation: Maintainer-authored CI/release improvement tied to the Snap gateway lifecycle work in #2055
Docs: CI.md, the release-canary skill, and CONTRIBUTING.md cover the Snap test path
Checks: Current-head Branch Checks and Branch E2E are queued or running; Helm Lint and DCO are green
E2E: test:e2e and test:snap are applied; current-head run 33519406557 is queued or running
Head SHA: 8df9f30cd35cb67cf6434a50069b3d253aff5aef
Base SHA: f1703254bb1f7605136734420f990fd00f3dfcf6
Merge base SHA: f1703254bb1f7605136734420f990fd00f3dfcf6
Patch ID: 69ccf8ec62538d87736169d546c3b3583188fc01
Gator payload: 7
Review mode: critical_only
Previous reviewed SHA: 4ed5fb9a7b4fa24d220edba68377badf9bbd46e5
Review budget exhausted: yes
Maintainer decision required: no
Next state: gator:watch-pipeline

elezar requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners August 21, 2026 10:26

elezar added the test:snap Requires Snap packaging and gateway lifecycle smoke coverage label Aug 21, 2026

elezar force-pushed the 2055-snap-pr-smoke/ek branch from 7d50815 to 3bbf47e Compare August 21, 2026 14:51

elezar force-pushed the 2055-snap-pr-smoke/ek branch 2 times, most recently from a66ebe5 to 3f771b4 Compare August 24, 2026 08:21

elezar force-pushed the 2055-snap-pr-smoke/ek branch from 3f771b4 to 4a7c134 Compare August 24, 2026 11:45

elezar force-pushed the 2055-snap-pr-smoke/ek branch from 4a7c134 to 4dfef75 Compare August 25, 2026 10:23

elezar force-pushed the 2055-snap-pr-smoke/ek branch from 4dfef75 to e68f04a Compare August 25, 2026 13:35

elezar force-pushed the 2055-snap-pr-smoke/ek branch from e68f04a to d8d5072 Compare August 25, 2026 13:36

elezar force-pushed the 2055-snap-pr-smoke/ek branch from d8d5072 to 8e73cd6 Compare August 25, 2026 13:56

elezar force-pushed the 2055-snap-pr-smoke/ek branch from 8e73cd6 to 0843e09 Compare August 25, 2026 14:02

johntmyers reviewed Aug 25, 2026

View reviewed changes

Comment thread .github/workflows/release-canary.yml Outdated

johntmyers added the gator:in-review Gator is reviewing or awaiting PR review feedback label Aug 25, 2026

elezar force-pushed the 2055-snap-pr-smoke/ek branch from 0843e09 to 2d6b888 Compare August 26, 2026 12:43

johntmyers reviewed Aug 26, 2026

View reviewed changes

johntmyers added gator:watch-pipeline Gator is monitoring PR CI/CD status and removed gator:in-review Gator is reviewing or awaiting PR review feedback gator:watch-pipeline Gator is monitoring PR CI/CD status labels Aug 26, 2026

github-advanced-security Bot found potential problems Aug 27, 2026

View reviewed changes

johntmyers reviewed Aug 27, 2026

View reviewed changes

elezar force-pushed the 2055-snap-pr-smoke/ek branch from 215657c to 4ed5fb9 Compare August 31, 2026 15:06

johntmyers reviewed Aug 31, 2026

View reviewed changes

elezar added 2 commits September 1, 2026 16:23

test(snap): smoke PR artifacts before release

66ae2e9

Signed-off-by: Evan Lezar <elezar@nvidia.com>

fix(ci): keep snap canary action on workflow revision

8df9f30

Signed-off-by: Evan Lezar <elezar@nvidia.com>

elezar force-pushed the 2055-snap-pr-smoke/ek branch from 4ed5fb9 to 8df9f30 Compare September 1, 2026 14:25

johntmyers reviewed Sep 1, 2026

View reviewed changes

johntmyers added gator:watch-pipeline Gator is monitoring PR CI/CD status gator:approval-needed Gator completed review; maintainer approval needed and removed gator:blocked Gator is blocked by process or repository gates gator:watch-pipeline Gator is monitoring PR CI/CD status labels Sep 1, 2026

Navigation Menu

Uh oh!

test(snap): smoke PR artifacts before release - #2869

test(snap): smoke PR artifacts before release#2869
elezar wants to merge 2 commits into
2055-snap-gateway-lifecycle/ekfrom
2055-snap-pr-smoke/ek

elezar commented Aug 21, 2026

Uh oh!

elezar commented Aug 21, 2026

Uh oh!

johntmyers left a comment

Uh oh!

Uh oh!

johntmyers left a comment

Uh oh!

Uh oh!

johntmyers commented Aug 27, 2026

Uh oh!

johntmyers left a comment

Uh oh!

johntmyers left a comment

Uh oh!

johntmyers commented Sep 1, 2026

Uh oh!

johntmyers left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

elezar commented Aug 21, 2026

Summary

Related Issue

Changes

Testing

Checklist

Uh oh!

elezar commented Aug 21, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

Re-check After Author Update

Uh oh!

Uh oh!

johntmyers commented Aug 27, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

Re-check After Author Update

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

Re-check After Author Update

Uh oh!

johntmyers commented Sep 1, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

Re-check After Author Update

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants