chore: Implement FindTensorRT module with component support#42
Closed
matiaslin wants to merge 1 commit intoNVIDIA:mainfrom
Closed
chore: Implement FindTensorRT module with component support#42matiaslin wants to merge 1 commit intoNVIDIA:mainfrom
matiaslin wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Collaborator
|
LGTM also. |
Author
|
Thank you all for the reviews! @nvluxiaoz, any updates on merging this PR? Thank you. |
Collaborator
|
We are in the process of merging it into Edge-LLM's internal CI. Expect to show up in the next 1 or 2 releases. Thanks a lot for the contribution! |
Author
|
Sounds good. Thank you for the update and for the reviews! |
Standardized TensorRT discovery by replacing manual header/library path checks with a find_package pattern. Implemented component handling to allow surgical linking of the ONNX parser. Updated documentation to clarify that TRT_PACKAGE_DIR is now a hint. Signed-off-by: malin <matiasenoclin@gmail.com> Signed-off-by: matiaslin <matiasenoclin@gmail.com>
matiaslin
force-pushed
the
find_tensorrt_dependency_discovery
branch
from
698439f to
3aec2e1
Compare
Author
|
Just rebased and resolved merge conflicts to make this PR ready for merge. |
Collaborator
|
This MR is included in https://github.com/NVIDIA/TensorRT-Edge-LLM/tree/release/0.7.0. Closing this as merged. Thanks! |
Author
|
Thank you @nvluxiaoz for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_packagepattern.What does this PR do?
We modernize the TensorRT discovery logic by implementing a
FindTensorRT.cmakemodule. This replaces the manual and fragmented include dirs and library discovery code with a standardizedfind_packagepattern.Usage
Checklist