Add text option to sphinx-build and update pyproject.toml dependencies #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mgluhovskoi
added
documentation
| import sys | ||
|
|
||
| ROOT_DIR = os.path.join(os.path.abspath(os.path.dirname(__file__)), os.path.pardir) | ||
| import sphinx_toolbox |
There was a problem hiding this comment.
Could we group this with the other imports?
| "nvidia-modelopt==0.11.1", | ||
| "transformers==4.44.2", | ||
| "datasets==2.21.0", | ||
| "nvidia-modelopt==0.29.0", |
There was a problem hiding this comment.
Could you make sure L1 passes with this change?
pranavm-nvidia
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation building with text mode before this resulted in an error due to
CollapseNodes. This changes should add support forCollapseNodeswith text build option while not interfering with the html build option. Part of this change also updates some of the dependencies, particularly sphinx-build and sphinx-toolboox which had some bugs when building documentation with different build options.