Skip to content

Conversation

matthewfl
Copy link
Contributor

This Adds a Raise normalization pattern that matches the tensorrt mlir that is generated by torch-mlir when lowering the layer norm layer.

@matthewfl matthewfl changed the title Raise Normalization for Pytorch (torch-mlir) Layer norm. [mlir-tensorrt] Raise Normalization for Pytorch (torch-mlir) Layer norm. Jul 28, 2025
@shelkesagar29 shelkesagar29 added the mlir-tensorrt Pull request for the mlir-tensorrt project label Jul 28, 2025
Copy link
Collaborator

@christopherbate christopherbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments otherwise LGTM. Thanks!

@shelkesagar29
Copy link
Collaborator

@matthewfl can you please squash commit and make sure resulted single commit has canonical commit message. CI is failing to run because of this. As soon as CI passes, I will merge this PR.

@matthewfl matthewfl force-pushed the mfl/raise-normalization branch from 992c265 to efe8de8 Compare August 6, 2025 16:41
@matthewfl
Copy link
Contributor Author

@shelkesagar29 I squashed the commits. I still see

Merging is blocked
Commits must have verified signatures.

Not sure if I need to configure a gpg key to sign the commits, or if this has something to do with owner/contributor of the repo.

@shelkesagar29
Copy link
Collaborator

shelkesagar29 commented Aug 6, 2025

@shelkesagar29 I squashed the commits. I still see

Merging is blocked
Commits must have verified signatures.

Not sure if I need to configure a gpg key to sign the commits, or if this has something to do with owner/contributor of the repo.

Yes, commit should say it's verified. You can do it by configuring GPG key. For now. I will merge this once CI passes.

@matthewfl matthewfl force-pushed the mfl/raise-normalization branch from efe8de8 to 13d98bd Compare August 6, 2025 16:56
This Adds a Raise normalization pattern that matches the tensorrt mlir
that is generated by torch-mlir when lowering the layer norm layer.

Signed-off-by: Matthew Francis-Landau <[email protected]>

add utils function of getSplatConstantElementAttribute

Signed-off-by: Matthew Francis-Landau <[email protected]>
@matthewfl matthewfl force-pushed the mfl/raise-normalization branch from 13d98bd to 2728cdb Compare August 6, 2025 16:57
@matthewfl
Copy link
Contributor Author

@shelkesagar29 I signed the commit with my personal gpg key.

I still don't see a "merge" button that I can click.

If you can merge when CI passes that would be great.

@shelkesagar29 shelkesagar29 merged commit deb6e79 into NVIDIA:main Aug 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir-tensorrt Pull request for the mlir-tensorrt project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants