-
Notifications
You must be signed in to change notification settings - Fork 17
[mlir-tensorrt] Raise Normalization for Pytorch (torch-mlir) Layer norm. #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments otherwise LGTM. Thanks!
mlir-tensorrt/tensorrt/lib/TensorRT/Transforms/RaiseNormalizations.pdll
Outdated
Show resolved
Hide resolved
mlir-tensorrt/tensorrt/lib/TensorRT/Transforms/RaiseNormalizations.pdll
Outdated
Show resolved
Hide resolved
mlir-tensorrt/tensorrt/lib/TensorRT/Transforms/RaiseNormalizations.pdll
Outdated
Show resolved
Hide resolved
@matthewfl can you please squash commit and make sure resulted single commit has canonical commit message. CI is failing to run because of this. As soon as CI passes, I will merge this PR. |
992c265
to
efe8de8
Compare
@shelkesagar29 I squashed the commits. I still see
Not sure if I need to configure a gpg key to sign the commits, or if this has something to do with owner/contributor of the repo. |
Yes, commit should say it's verified. You can do it by configuring GPG key. For now. I will merge this once CI passes. |
efe8de8
to
13d98bd
Compare
This Adds a Raise normalization pattern that matches the tensorrt mlir that is generated by torch-mlir when lowering the layer norm layer. Signed-off-by: Matthew Francis-Landau <[email protected]> add utils function of getSplatConstantElementAttribute Signed-off-by: Matthew Francis-Landau <[email protected]>
13d98bd
to
2728cdb
Compare
@shelkesagar29 I signed the commit with my personal gpg key. I still don't see a "merge" button that I can click. If you can merge when CI passes that would be great. |
This Adds a Raise normalization pattern that matches the tensorrt mlir that is generated by torch-mlir when lowering the layer norm layer.