#343: Support collections of tensors in args/kwargs for compile #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilg-nv
changed the title
| if any(isinstance(v, (InputInfo, DimensionInputInfo)) for v in arg.values()): | ||
| input_names.add(name) | ||
| result = {} | ||
| for key, value in arg.items(): |
There was a problem hiding this comment.
What if the keys are not strings/implicitly convertible to strings?
Comment on lines
+296
to
+298
| for nested_name in sorted(trace_input_map.keys()): | ||
| if nested_name.startswith(f"{name}.") or nested_name.startswith(f"{name}["): | ||
| nested_tensors.append(trace_input_map[nested_name].trace_tensor) |
There was a problem hiding this comment.
Can we just populate the trace_input_map as we call process_arg instead of doing this extra step?
|
|
||
| # Handle containers of InputInfo objects | ||
| if isinstance(arg, dict): | ||
| if any(isinstance(v, (InputInfo, DimensionInputInfo)) for v in arg.values()): |
There was a problem hiding this comment.
This check needs to be removed to support nested collections. Same for lists below.
Comment on lines
+222
to
+223
| else: | ||
| return [] |
There was a problem hiding this comment.
When is this branch reached?
Comment on lines
+220
to
+221
| if name_prefix in input_info_names: | ||
| return [tensor] |
There was a problem hiding this comment.
We can pull this out to the top of the extract_recursive method and that'll also let you drop the checks on lines 204 and 214 (i.e. you can unconditionally make the recursive call).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.