[None][chore] Deprecate eagle3 2-model#11761
Conversation
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
📝 WalkthroughWalkthroughUpdated deprecation warning messages for Eagle and MTP decoding configurations in the LLM API arguments module to clarify removal timelines. Changes indicate that Eagle3 2-model style and 2-model MTP will be removed in release 1.4. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tensorrt_llm/llmapi/llm_args.py`:
- Around line 917-920: The deprecation warning currently uses a truthy check
that also fires when eagle3_one_model is None; change the condition in the block
that calls logger.warning so it only runs when self.eagle3_one_model is
explicitly False (e.g., replace "if not self.eagle3_one_model" with an explicit
comparison against False) so the message only appears when the 2-model option
was intentionally selected.
|
/bot run |
|
PR_Github #36986 [ run ] triggered by Bot. Commit: |
|
PR_Github #36986 [ run ] completed with state
|
|
/bot run |
|
PR_Github #37109 [ run ] triggered by Bot. Commit: |
|
PR_Github #37109 [ run ] completed with state
|
|
/bot run |
|
PR_Github #37359 [ run ] triggered by Bot. Commit: |
|
PR_Github #37359 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #37373 [ run ] triggered by Bot. Commit: |
|
PR_Github #37373 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #37530 [ run ] triggered by Bot. Commit: |
|
PR_Github #37530 [ run ] completed with state |
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
4 participants
Description
Add a deprecation warning for 2-model/static trees.
Test Coverage
N/A
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit
Release Notes
Deprecation Notices