Skip to content

[https://nvbugs/5907477][chore] unwaive test#11896

Merged
reasonsolo merged 1 commit intoNVIDIA:mainfrom
reasonsolo:bug5907477
Mar 5, 2026
Merged

[https://nvbugs/5907477][chore] unwaive test#11896
reasonsolo merged 1 commit intoNVIDIA:mainfrom
reasonsolo:bug5907477

Conversation

@reasonsolo
Copy link
Collaborator

@reasonsolo reasonsolo commented Mar 4, 2026

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped test to expand test coverage and improve validation of auto dtype functionality.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@reasonsolo
Copy link
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

📝 Walkthrough

Walkthrough

This pull request removes a test skip entry from a waiver file, enabling a previously skipped accuracy test (accuracy/test_disaggregated_serving.py::TestDeepSeekV32Exp::test_auto_dtype[False]) to execute in test runs.

Changes

Cohort / File(s) Summary
Test Waiver Configuration
tests/integration/test_lists/waives.txt
Removed a SKIP entry for a specific test case, allowing it to run in the test execution pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely blank with no content provided in the required sections: Description, Test Coverage, and PR checklist items are unchecked. Fill in the Description section explaining why the test is being unwaived and add Test Coverage details. Complete the PR checklist items appropriately for the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly describes the main change: removing a SKIP entry to enable a previously skipped test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37636 [ run ] triggered by Bot. Commit: 4cc7e26 Link to invocation

@reasonsolo reasonsolo requested a review from EmmaQiaoCh March 4, 2026 08:36
@tensorrt-cicd
Copy link
Collaborator

PR_Github #37636 [ run ] completed with state SUCCESS. Commit: 4cc7e26
/LLM/main/L0_MergeRequest_PR pipeline #29126 completed with status: 'SUCCESS'

Link to invocation

@reasonsolo reasonsolo enabled auto-merge (squash) March 5, 2026 06:17
@reasonsolo reasonsolo merged commit 12f2f39 into NVIDIA:main Mar 5, 2026
9 of 10 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
tianyuz-nv pushed a commit to wanqian-nv/TensorRT-LLM that referenced this pull request Mar 19, 2026
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
limin2021 pushed a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants