[TRTLLM-9911] [doc] Update Perf-Overview.md for Release 1.2#12098
[TRTLLM-9911] [doc] Update Perf-Overview.md for Release 1.2#12098zbpatel wants to merge 3 commits intoNVIDIA:release/1.2from
Conversation
📝 WalkthroughWalkthroughDocumentation update to the performance overview guide adding CPU Affinity configuration guidance, hardware variants (B300, GB300), and expanding model lists with six FP4 and five FP8 model entries. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/source/developer-guide/perf-overview.md`:
- Line 41: Update the GB300 entry to include its memory capacity for consistency
with the other GPU lines: locate the line containing "GB300 (GB300 NVL72)" and
replace it with the same label plus the correct memory size (e.g., "GB300 192GB
(GB300 NVL72)"), ensuring the format matches other entries like "B300 288GB" and
"GB200 192GB".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6e59fe65-b728-481a-8bad-004fabb98f62
📒 Files selected for processing (1)
docs/source/developer-guide/perf-overview.md
| - B200 180GB (DGX B200) | ||
| - B300 288GB (DGX B300) | ||
| - GB200 192GB (GB200 NVL72) | ||
| - GB300 (GB300 NVL72) |
There was a problem hiding this comment.
Add memory specification for GB300 to maintain consistency.
All other GPU entries in the hardware list include memory capacity (e.g., "B300 288GB", "GB200 192GB"), but the GB300 entry is missing this specification. Please add the memory size to maintain format consistency.
📝 Suggested fix
-- GB300 (GB300 NVL72)
+- GB300 {MEMORY_SIZE}GB (GB300 NVL72)Replace {MEMORY_SIZE} with the appropriate memory capacity for GB300.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/source/developer-guide/perf-overview.md` at line 41, Update the GB300
entry to include its memory capacity for consistency with the other GPU lines:
locate the line containing "GB300 (GB300 NVL72)" and replace it with the same
label plus the correct memory size (e.g., "GB300 192GB (GB300 NVL72)"), ensuring
the format matches other entries like "B300 288GB" and "GB200 192GB".
569350e to
6d4aab6
Compare
Signed-off-by: Zachary Patel <22306219+zbpatel@users.noreply.github.com>
Signed-off-by: Zachary Patel <22306219+zbpatel@users.noreply.github.com>
6d4aab6 to
407c2ed
Compare
|
/bot skip "doc update" |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot skip --comment "doc update" |
|
PR_Github #38639 [ skip ] triggered by Bot. Commit: |
Signed-off-by: Zachary Patel <22306219+zbpatel@users.noreply.github.com>
This MR updates the performance overview documentation based on the results of the performance testing done for the 1.2 release. Performance benchmarking was conducted by @flin3500
Status:
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.