[#12071][fix] Replace cudaMemcpy2DAsync with flat copy in copyKvBlockOffsets#12111
Open
wojciech-wais wants to merge 2 commits intoNVIDIA:mainfrom
Open
[#12071][fix] Replace cudaMemcpy2DAsync with flat copy in copyKvBlockOffsets#12111wojciech-wais wants to merge 2 commits intoNVIDIA:mainfrom
wojciech-wais wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…vBlockOffsets Replace cudaMemcpy2DAsync with BufferManager::copy (flat async memcpy) for copying KV cache block offsets from host to device. The 2D copy was an optimization to skip zero-padded columns, but it triggered cudaErrorInvalidPitchValue with large beam widths (e.g. beam_width=128). The flat copy is semantically equivalent since both host and device tensors share the same shape and the host tensor is fully prepared (zeroed then populated). The performance difference is negligible as this is a small metadata buffer. Also add validation assertions to catch block count vs max blocks per sequence inconsistencies early with clear error messages. Signed-off-by: Wojciech Wais <wojciech.wais@gmail.com>
1d8dd51 to
f1528c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace cudaMemcpy2DAsync with BufferManager::copy (flat async memcpy) for copying KV cache block offsets from host to device. The 2D copy was an optimization to skip zero-padded columns, but it triggered cudaErrorInvalidPitchValue with large beam widths (e.g. beam_width=128).
The flat copy is semantically equivalent since both host and device tensors share the same shape and the host tensor is fully prepared (zeroed then populated). The performance difference is negligible as this is a small metadata buffer.
Also add validation assertions to catch block count vs max blocks per sequence inconsistencies early with clear error messages.
Summary by CodeRabbit
Bug Fixes
Refactor
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.