[None][fix] piecewise cudagraph node name for gemma-3-1b-it#12131
Open
amukkara wants to merge 1 commit intoNVIDIA:mainfrom
Open
[None][fix] piecewise cudagraph node name for gemma-3-1b-it#12131amukkara wants to merge 1 commit intoNVIDIA:mainfrom
amukkara wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Anurag Mukkara <134339030+amukkara@users.noreply.github.com>
Contributor
📝 WalkthroughWalkthroughChanges remove a configuration parameter from an example file and refine backend compilation logic to initialize a variable, expand placeholder name matching to include an additional pattern, and add early termination after capturing input token counts. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
l_kwargs_input_ids_. For other models, the node name isl_input_ids_. This PR pattern matches against both names when estimating input_num_tokens.TorchCompileConfig.enable_inductor=Falsein example script to avoid conflict with piecewise_cuda_graph.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.