Skip to content

[None][fix] write per-rank torch profile traces #13536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GavinZhu-GMI wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

[None][fix] write per-rank torch profile traces #13536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tensorrt_llm/_torch/pyexecutor/py_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,6 +936,14 @@ def _profiler(self):
prev_device_step_time = None

torch_trace_path = os.environ.get(PROFILE_TRACE_ENV_VAR_NAME, None)
if torch_trace_path is not None:
# Append the rank so each rank writes to its own file. Without
# this, TP/PP/DP > 1 runs have every rank calling
# torch_profiler.export_chrome_trace() on the same path
# concurrently, producing interleaved output that fails to
# parse in Chrome tracing / Perfetto.
trace_base, trace_ext = os.path.splitext(torch_trace_path)
torch_trace_path = f"{trace_base}-rank-{self.global_rank}{trace_ext}"
profile_start_stop = os.environ.get(PROFILE_START_STOP_ENV_VAR_NAME,
None)
enable_torch_trace = bool(torch_trace_path and profile_start_stop)
Expand Down