[None][infra] Add dev-container entrypoint dispatcher for CLI docker workflow#16574
Draft
jieli-matrix wants to merge 1 commit into
Draft
[None][infra] Add dev-container entrypoint dispatcher for CLI docker workflow#16574jieli-matrix wants to merge 1 commit into
jieli-matrix wants to merge 1 commit into
Conversation
…workflow Introduce .devcontainer/entrypoint.dev.sh, a build/test dispatcher for a CLI-only (non-VSCode) docker container dev loop: build-full, build-cpp, build-python, build-precompiled, test, build-and-test, wait, shell. All build state (ccache, cpp/build, symlinked .so) lives on the mounted host tree, so the container stays disposable and rebuilds are incremental across container/branch churn. This is the shared entrypoint for a docker-compose based develop-and-repro workflow (WIP, draft). Signed-off-by: Jie Li <lijie@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The only supported container dev flow today is the VSCode Dev Container (
.devcontainer/).For a CLI-only developer it is a poor fit, and there
is no first-class path for the everyday bug-repro-and-fix loop: pull image → mount TOT +
model data → build (ccache, correct GPU arch) →
pytestto repro → branch → incrementalrebuild →
pytestto validate.This PR adds a CLI-only, docker-compose develop-and-repro workflow that sits beside the
VSCode flow (which stays untouched), with a clean
up -d→execloop and no generated env file.Scope — where this runs, and what it does / doesn't cover
The two modes (rootful / rootless) select for docker daemon. Mapping to real environments:
-u root:root,--privileged)srunjobs)--container-remap-root)examples/disaggregated/slurm/Insights & analysis
The VSCode flow doesn't transfer to CLI. It depends on
make_env.pygenerating.devcontainer/.env(run as VSCode'sinitializeCommand), anddocker-compose.yml's commandis just
while sleep 1000— a keep-alive with no build/test ergonomics.up -d+execbeatsrun -it. Start a detached, named container once; drive builds/testsvia
exec.TODO
.devcontainer/entrypoint.dev.sh— build/test dispatcher (build-full / build-cpp /build-python / build-precompiled / test / build-and-test / wait / shell). (first commit)
docker/compose.dev.yml(base:ipc: host,network_mode: host,init: true,shm_size1g/
DEV_SHM_SIZE,ulimits.stack=67108864, caps — cluster runtime parity for single-nodedisagg) +
docker/compose.dev.rootful.yml(addsuser:+ulimit memlock=-1)docker/devwrapper — repo-local-f/--env-file;DEV_ROOTLESS=0|1selectordocker/compose.dev.override.yml.example,docker/dev.user.env.example(git-ignore the real files)nativein the entrypoint (fix the90-realdefault)cpp/build/.built_with_image) → warn tobuild-full --cleanon tag change@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.