[https://nvbugs/6305365][chore] Unwaive piecewise cudagraph related tests#16591
Conversation
Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
|
/bot run --stage-list "DGX_H100-PyTorch-Post-Merge-1, DGX_H100-PyTorch-Post-Merge-2" |
📝 WalkthroughWalkthroughRemoved four SKIP waivers from the integration test list, re-enabling selected DeepSeekV3Lite and Llama3.1 8B Instruct bfloat16 test configurations. ChangesAccuracy test waiver updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #60269 [ run ] triggered by Bot. Commit: |
|
PR_Github #60269 [ run ] completed with state
|
|
/bot run --stage-list "DGX_H100-PyTorch-Post-Merge-1, DGX_H100-PyTorch-Post-Merge-2" |
|
PR_Github #60279 [ run ] triggered by Bot. Commit: |
|
PR_Github #60279 [ run ] completed with state
|
|
/bot run --stage-list "DGX_H100-PyTorch-Post-Merge-1, DGX_H100-PyTorch-Post-Merge-2" |
|
PR_Github #60292 [ run ] triggered by Bot. Commit: |
|
PR_Github #60292 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #60337 [ run ] triggered by Bot. Commit: |
|
PR_Github #60337 [ run ] completed with state |
Summary by CodeRabbit
Description
Root cause was stale torch-compile piecewise CUDA Graph state surviving ModelEngine/Python executor teardown. The previous cleanup released the regular CUDA Graph runners but did not clear PiecewiseRunner captures, cached input/output addresses, static outputs, or their private graph-pool state. A later executor could therefore replay a graph captured against the previous executor lifetime, resulting in cudaErrorLaunchFailure during attention warmup.
This was fixed by commit 211482b, see #15923. The fix invokes Backend.clear_piecewise_cuda_graphs() from ModelEngine._release_cuda_graphs(), resets all tracked PiecewiseRunner capture state, and rotates dead private graph-pool handles.
This PR removes related tests from
waives.txt.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.