[https://nvbugs/6468821][chore] Unwaive GPT-OSS B300 attention backend test#16616
Conversation
|
/bot run --disable-fail-fast |
…d test Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe integration waiver list removes one B300 waiver for an attention backend test. All subsequent waiver entries remain unchanged. ChangesWaiver cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #60344 [ run ] triggered by Bot. Commit: |
|
PR_Github #60344 [ run ] completed with state
|
BowenFu
left a comment
There was a problem hiding this comment.
LGTM — waiver removal (unwaive GPT-OSS on B300) after the underlying bug (6468821) was resolved; test-list only, no product code.
|
/bot run --disable-fail-fast |
|
PR_Github #60377 [ run ] triggered by Bot. Commit: |
|
PR_Github #60377 [ run ] completed with state |
Summary by CodeRabbit
Description
Remove the B300 waiver for the GPT-OSS GQA BF16 context attention-backend test tracked by NVBug 6468821. The exact test selector passed 100 consecutive standalone runs on B300 without reproducing the reported failure.
Test Coverage
tests/unittest/_torch/attention/test_attention_backends.py::test_attention_backend[gpt_oss_gqa_hd64_gptj_swa128-ctx-bf16-HND-p32-v1]on B300: 100/100 passed.tests/unittest/_torch/attention/on B300: two complete repetitions passed (3,600 passed and 536 skipped per repetition).PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.