Skip to content

[https://nvbugs/6468821][chore] Unwaive GPT-OSS B300 attention backend test#16616

Merged
yuxianq merged 1 commit into
NVIDIA:mainfrom
yuxianq:debug/test-attention-backend-gpt-oss
Jul 21, 2026
Merged

[https://nvbugs/6468821][chore] Unwaive GPT-OSS B300 attention backend test#16616
yuxianq merged 1 commit into
NVIDIA:mainfrom
yuxianq:debug/test-attention-backend-gpt-oss

Conversation

@yuxianq

@yuxianq yuxianq commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed an obsolete test waiver for an attention backend integration test.

Description

Remove the B300 waiver for the GPT-OSS GQA BF16 context attention-backend test tracked by NVBug 6468821. The exact test selector passed 100 consecutive standalone runs on B300 without reproducing the reported failure.

Test Coverage

  • tests/unittest/_torch/attention/test_attention_backends.py::test_attention_backend[gpt_oss_gqa_hd64_gptj_swa128-ctx-bf16-HND-p32-v1] on B300: 100/100 passed.
  • tests/unittest/_torch/attention/ on B300: two complete repetitions passed (3,600 passed and 536 skipped per repetition).
  • Waiver parser: all 455 remaining entries parsed successfully.
  • Pre-commit waiver duplicate and AST test-list validation hooks passed.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@yuxianq

yuxianq commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

…d test

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fddfcf0c-de71-4a24-a382-39d3fb11d50a

📥 Commits

Reviewing files that changed from the base of the PR and between b8604c4 and a33e706.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

The integration waiver list removes one B300 waiver for an attention backend test. All subsequent waiver entries remain unchanged.

Changes

Waiver cleanup

Layer / File(s) Summary
Remove attention backend waiver
tests/integration/test_lists/waives.txt
Deletes the SKIP waiver entry for the targeted attention backend test.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the PR’s main change and uses the required ticket/type format.
Description check ✅ Passed The description includes the required Description, Test Coverage, and PR Checklist sections and is specific enough.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60344 [ run ] triggered by Bot. Commit: a33e706 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60344 [ run ] completed with state FAILURE. Commit: a33e706
/LLM/main/L0_MergeRequest_PR pipeline #48686 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@BowenFu BowenFu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — waiver removal (unwaive GPT-OSS on B300) after the underlying bug (6468821) was resolved; test-list only, no product code.

@yuxianq

yuxianq commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60377 [ run ] triggered by Bot. Commit: a33e706 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60377 [ run ] completed with state SUCCESS. Commit: a33e706
/LLM/main/L0_MergeRequest_PR pipeline #48716 completed with status: 'SUCCESS'

CI Report

Link to invocation

@yuxianq
yuxianq merged commit dea4306 into NVIDIA:main Jul 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants